PMM-15160 Feature build for QAN sparkline fix - #4540
Draft
theTibi wants to merge 1 commit into
Draft
Conversation
Build PMM server and client from the percona/pmm branch that stops qan-api2 panicking with an integer divide by zero when a QAN report's time range collapses into a single minute. Component PR: percona/pmm#5824 Signed-off-by: theTibi <tkorocz@gmail.com>
10 tasks
Collaborator
|
Server docker: perconalab/pmm-server-fb:PR-4540-098ec76 |
Collaborator
|
API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7123/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature build for PMM-15160 — https://perconadev.atlassian.net/browse/PMM-15160
Builds PMM Server and Client from the
percona/pmmbranch that stopsqan-api2panicking with an integer divide by zero when a QAN report's time range collapses into a single minute.Component PRs
ci.yml
Single repo — the change is confined to
qan-api2/. No grafana-fork, exporter or pmm-qa branch is involved.What to check in the built image
Server-side only; no client involvement. Against a PMM with some QAN data:
time_frame: 60). Before this change it was 500{"code":13,"message":"Internal server error."}plus a stack in/srv/logs/qan-api2.log:POST /v1/qan:getMetricswith the same range.period_start_from == period_start_to,getReport,getMetricsandgetFiltersmust contain no"Infinity"or"NaN"in any float field.getFilterspreviously returned 24 of each; the generated API clients cannot decode either.from > toongetReport,getMetrics(includingtotals: true) andgetFiltersmust return 400InvalidArgument, not 500 and not a fabricated data point.Draft, per the FB convention — to be closed once the component PR merges.