PMM-15184 Feature build for Disk Details stacking fix - #4539
Draft
theTibi wants to merge 1 commit into
Draft
Conversation
Build PMM server and client from the percona/pmm branch that fixes the Disk Details mountpoint panel: Used+Free no longer double-counts capacity, and the legend regains its Mean/Max/Min columns. Component PR: percona/pmm#5823 Signed-off-by: theTibi <tkorocz@gmail.com>
9 tasks
Collaborator
|
Server docker: perconalab/pmm-server-fb:PR-4539-39215d1 |
Collaborator
|
API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7120/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature build for PMM-15184 — https://perconadev.atlassian.net/browse/PMM-15184
Builds PMM Server and Client from the
percona/pmmbranch that fixes the Disk Details mountpoint panel.Component PRs
ci.yml
Single repo — the change is one file,
dashboards/dashboards/OS/Disk_Details.json(panel1023). No grafana-fork, exporter or pmm-qa branch is involved.What to check in the built image
Open Disk Details for a node with a large disk, expand the Disk Space row, and look at the Mountpoint $mountpoint panel:
Used+Freestack tops out at the device's true capacity, not 2× it. Onorigin/maina 47.7 TiB device renders a ~96 TiB stack; verified locally as 58.4 GiB instead of ~117 GiB on a 58.37 GiB device.Totalrenders as an unfilled dark-red reference line lying along the top of the stack — not as a filled band stacked above it.Last.Nothing else in the dashboard should change: all 21 panel ids, the
node-diskuid, and every query and unit are untouched, so existing deep links must keep working.Draft, per the FB convention — to be closed once the component PR merges.