Skip to content

add animated loaders extension - #626

Open
Ikelene wants to merge 2 commits into
PenguinMod:mainfrom
Ikelene:animatedLoaders
Open

add animated loaders extension#626
Ikelene wants to merge 2 commits into
PenguinMod:mainfrom
Ikelene:animatedLoaders

Conversation

@Ikelene

@Ikelene Ikelene commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

its just animated loaders idk what else to say

@sakurabuilder

sakurabuilder Bot commented Aug 20, 2026

Copy link
Copy Markdown

✅ Preview ready

Your changes are live at: https://jolly-badger-b0843f4e.skr.mubilop.com/

Built from 56fa806

@jwklong

jwklong commented Aug 20, 2026

Copy link
Copy Markdown
Member

wheeere is the css from

@Ikelene

Ikelene commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

pma-ring is mine, others are from a mix of claude (the progress bars were modified by me a little) and css-loaders.com
users can also import any custom loader they want from sites like https://css-loaders.com/

@jwklong

jwklong commented Aug 20, 2026

Copy link
Copy Markdown
Member

wouldnt custom loaders mean a xss vuln

@Ikelene

Ikelene commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

idk, should i remove it then? it kinda does let you run custom CSS so i would guess yes

@Ikelene

Ikelene commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

there fixed should be good for merge now if theres nothing else

@Steve0Greatness

Copy link
Copy Markdown
Contributor

I'm not actually opposed to allowing custom CSS, as long as there's some sort of sandboxing for custom loaders (like maybe having it in an iframe with some styling to hide that fact).

@Ikelene

Ikelene commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

I'm not actually opposed to allowing custom CSS, as long as there's some sort of sandboxing for custom loaders (like maybe having it in an iframe with some styling to hide that fact).

I didn't actually think of that, that's a good idea. I think it's definitely something I'll toy with later, jwklong just didn't answer me for a bit so I just thought I'd remove it so I don't have to wait another 5 business days for another response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants