-
Notifications
You must be signed in to change notification settings - Fork 189
Added Complex Numbers extension #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c68bb50
1db3c72
ca51432
21cc1b0
76e7fa7
12eb93b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -331,6 +331,18 @@ export default [ | |
| isGitHub: true, | ||
| tags: ["new", "customtype", "3D", "data", "utility", "math"] | ||
| }, | ||
| { | ||
| name: "Complex Numbers", | ||
| description: "Complex Number Type for do complex analysis functions, better implementation than the one made by jwklong in Mathemathics extension lmao.", | ||
| code: "salagata/reisenComplex.js", | ||
| banner: "salagata/reisenComplex_placeholder.svg", | ||
|
Comment on lines
+337
to
+338
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just about directory arrangement: since your extension is under your own directory, you don't need to add a prefix to the filename (note that the ID should still have a prefix, just that the filename doesn't need one, the directory structure already essentially does that for you). |
||
| creator: "salagata", | ||
| tags: ["new","complex", "math", "graphics", "customtype", "utility"], | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Graphics? Please explain what this has to do with graphics.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Things where rotations are involved. Since complex numbers are perfect for rotations, rotating a complex number is just multiplying a polar number with an absolute value of 1 (r=1) and with a defined angle (\theta), instead of rotating vectors, they use A Matrix for rotate. The complex numbers are better for this kind of things involving rotation in graphics.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will see if i do an alternative system, i.e. , maybe choosing the mode when you want to do the, i.e. division. |
||
| creatorAlias: "Reisen the Inaba", | ||
| notes: "Additional help by jwklong extensions", | ||
| unstable: false, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It not being unstable is assumed by default, so you don't need to (and in fact probably shouldn't) specify it. |
||
| isGitHub: true, | ||
| }, | ||
| { | ||
| name: "Blobs", | ||
| description: "An extension made for handling blobs which can be used to store files. Allows to easily make blobs for the Js extension", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptions are to describe your extension, for this, there's really no reason to mention another extension in your case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... sorry I just ... N-NVM forget I did that-