Skip to content

Modify match and match cycle columns #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rootandroo merged 1 commit into from
Aug 31, 2026
Merged

Modify match and match cycle columns #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions db/migration/V0006__Alter_match_cycles_and_matches.sql
View file
Open in desktop
Comment thread
rootandroo marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@

ALTER TABLE "match_cycles"
ADD COLUMN "is_draft" BOOLEAN NOT NULL DEFAULT TRUE,
DROP COLUMN "total_matched",
DROP COLUMN "total_members";
Comment thread
rootandroo marked this conversation as resolved.


ALTER TABLE "matches"
DROP COLUMN "feedback_a",
DROP COLUMN "feedback_b";
6 changes: 0 additions & 6 deletions src/main/java/org/patinanetwork/patchats/api/match/db/models/Match.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,5 @@ public class Match {
@Setter
private String status;

@Setter
private String feedbackA;

@Setter
private String feedbackB;

private Instant createdAt;
}
6 changes: 0 additions & 6 deletions src/main/java/org/patinanetwork/patchats/api/match/db/models/MatchCycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,4 @@ public class MatchCycle {

@Setter
private Instant runAt;

@Setter
private Integer totalMembers;

@Setter
private Integer totalMatched;
}
5 changes: 5 additions & 0 deletions src/main/java/org/patinanetwork/patchats/api/match/design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@

## DTO

### Cycle field semantics

- `runAt`: when the system acts for the cycle — pairs are generated and notifications are sent out.
- `period`: which month the round is *for* (e.g. "2026-07"). Label used for display/filtering; normally derived from `runAt`, but may intentionally diverge if a run slips into another month.

`MatchStatus`: PENDING | CONFIRMED | COMPLETED | CANCELLED | SKIPPED

### Admin Match Cycles
Expand Down
Loading