fix(galaxy): link the Zenodo deposit by record URL rather than by DOI - #19
Merged
Conversation
The tools-iuc lint job resolves any doi.org link found in help text against CrossRef. Zenodo DOIs are registered with DataCite, so the doi.org link in the marker help returned 404 there and failed their lint. Only classify and split-fastq failed, which is what located it: those are the two tools that expand the marker help. The same DOI appears as a citation in all five, and in predict's parameter help as a bare doi: reference, and neither of those is URL-checked. The citation is therefore left as it was. Found by reproducing their exact lint invocation locally rather than the weaker one used before, which omitted --ensure_metadata and --urls and so never checked a link.
github-actions
Bot
added
the
area:galaxy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tools-iuc lint job failed on galaxyproject/tools-iuc#8318.
Their lint resolves any
doi.orglink it finds in help text against CrossRef. Zenodo DOIs are registered with DataCite, so that link can never resolve there.How it was located
Only
classifyandsplit-fastqfailed, not all five. Those two are exactly the tools that expand@MARKER_HELP@, which carriedhttps://doi.org/10.5281/zenodo.19210044.The same DOI appears as a
<citation type="doi">in all five tools, and inpredict's parameter help as a baredoi:reference. Neither of those failed, which proves the URL checker reads help text only and does not touch citations. So the citation is left exactly as it was, and only the help link changed.https://zenodo.org/records/19210044returns 200 and is now reported asURL OK.Why it was not caught before
The lint I ran locally was weaker than theirs. Theirs is:
Mine omitted
--ensure_metadataand--urls, so no link was ever checked. Reproducing their exact invocation now givesexit=0, with both URLs reported OK.