fix(ci): point the validator test step at the test files - #17
Merged
Conversation
`node --test .github/scripts/` treats the directory as a module to execute and dies with MODULE_NOT_FOUND, so the step failed for its own reasons on its first real run, before it could check anything. The marker validation never got as far as reading the proposal. The command was never run in the form the workflow used. It was verified locally as `cd .github/scripts && node --test`, which discovers test files in the current directory, and then written into the workflow as a path argument, which does not. Naming the files works, and was checked in both directions: it exits 0 with the validator intact and 1 with the single-character allele bug reintroduced, so the step still gates the comment on the tests actually passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node --test .github/scripts/treats the directory as a module to execute and dies withMODULE_NOT_FOUND. The step failed for its own reasons on its first real run, before it could check anything, so the marker validation never reached the proposal.The command was never run in the form the workflow used: it was verified locally as
cd .github/scripts && node --test, which discovers test files in the current directory, then written into the workflow as a path argument, which does not.Naming the files works, and was checked in both directions: exit 0 with the validator intact, exit 1 with the single-character allele bug reintroduced. The step still gates the comment on the tests actually passing.