Fix corruption source crash with fifth implicit - #10306
Open
mcagnion wants to merge 1 commit into
Open
Conversation
Reset corruption implicit selections without callbacks before rebuilding source-specific lists. This prevents a fifth Glimpse of Chaos implicit from invoking Scourge logic against a missing sixth control. Addresses the regression from PR 10206.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
PR #10206 added five-slot Glimpse of Chaos corruption support, but changing Source reset implicit selections only after switching modes and rebuilding source-specific lists. With Implicit #5 selected, switching to Scourge invoked its callback under Scourge pairing rules and attempted to access a nonexistent Implicit #6 control.
This change clears all implicit selections without callbacks before changing Source and rebuilding the lists, preserving the existing reset behavior without the crash.
Steps taken to verify a working solution: