Skip to content

Fix required levels for corrupted crafted items - #10302

Open
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix-corrupted-implicit-required-level
Open

Fix required levels for corrupted crafted items#10302
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix-corrupted-implicit-required-level

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Fixes # Couldn't find an issue for this

Description of the problem being solved:

When you apply a corruption to an item through the Craft of Edit item workflows, the required level of the item doesn't get updated based on the corrupted implicit.

The fix retains the selected modifier ID using PoB’s existing item metadata. It calculates the required level from the base, crafted affixes, and corrupted implicits using the existing 80% modifier-level rule. It only applies when the user corrupts an item through the Items tab. Imported and pasted items do not get recalculated (I'm trusting that data to be accurate and it allows a user to manually edit the item if desired).

Four regression tests cover the calculation, conservative behavior, metadata persistence, and later affix changes.

Steps taken to verify a working solution:

  • Crafted and Edit many different items with multiple different corrupted implicits
  • Verified against in-game required item levels
  • Tested applying the implicits in different orders (implicit 1 and 2) to ensure that the highest level requirement still applied

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant