Added support for Decree of Loyalty mods - #2497
Open
ntcarlson wants to merge 3 commits into
Open
Conversation
These are "Convert 1% of maximum Life to twice as much Armour per 1% Chaos Resistance above 0%" and "Defend with (150-200)% of Armour while you have Energy Shield".
LocalIdentity
requested changes
Sep 1, 2026
| ["you can socket an additional copy of each lineage support gem, in different skills"] = { mod("MaxLineageCount", "BASE", 1) }, | ||
| ["you can socket (%d+) additional copies of each lineage support gem, in different skills"] = function(num) return { mod("MaxLineageCount", "BASE", num) } end, | ||
| ["convert 1%% of maximum life to twice as much armour per 1%% chaos resistance above 0%%"] = { | ||
| mod("LifeConvertToArmour", "BASE", 1, { type = "PerStat", stat = "ChaosResist"}), |
Contributor
There was a problem hiding this comment.
This should use a function to grab the convert and the per chaos res value, not use hard coded 1% for each
Author
There was a problem hiding this comment.
Alright, I corrected that issue. I wasn't sure whether the numbers should be integers or decimals, but I made it accept decimal values as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the following Decree of Loyalty unique modifiers:
I left the final "Damage over time cannot bypass Energy Shield" modifier unimplemented because I am not sure how to handle it.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: