Cache tooltip assets - #2493
Merged
LocalIdentity merged 2 commits intoAug 30, 2026
Merged
Conversation
This solves two problems: - Item influence icons were being allocated and loaded on **every** frame while the tooltip was open. - Every tooltip was allocating and loading its own header and separator images, even though most of them share the same images. As a consequence, tooltip assets now stay loaded and do not get freed. This is fine because they're fairly small and commonly used anyway.
Unknown tooltip types should use the normal header assets, but the new cache indexed the unknown type directly and crashed. Resolve unknown types to the normal header before loading and caching their images.
LocalIdentity
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache tooltip header, influence icon, and separator image handles.
This solves two problems:
As a consequence, tooltip assets now stay loaded and do not get freed. This is fine because they're fairly small and commonly used anyway.
PoB1 PR: PathOfBuildingCommunity/PathOfBuilding#10311