Repository navigation
Conversation
rbev
changed the title
warwickschroeder
approved these changes
Nov 3, 2026
| if (maintenanceMode && !persistenceConfiguration.SupportsMaintenanceMode) | ||
| { | ||
| throw new Exception($"Maintenance mode is not supported by the {settings.PersistenceType} persister. It is only available on RavenDB, where it starts the embedded database so RavenDB Studio can be used."); | ||
| throw new Exception($"Maintenance mode is not supported by the {settings.StorageType} persister. It is only available on RavenDB, where it starts the embedded database so RavenDB Studio can be used."); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new Exception($"Maintenance mode is not supported by the {settings.StorageType} persister. It is only available on RavenDB, where it starts the embedded database so RavenDB Studio can be used."); | |
| throw new Exception($"Maintenance mode is not supported by the {settings.StorageType} storage type. It is only available on RavenDB, where it starts the embedded database so RavenDB Studio can be used."); |
| if (!persistenceConfiguration.SupportsMaintenanceMode) | ||
| { | ||
| throw new InvalidOperationException($"Maintenance mode is not supported by the {settings.PersistenceType} persister."); | ||
| throw new InvalidOperationException($"Maintenance mode is not supported by the {settings.StorageType} persister."); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new InvalidOperationException($"Maintenance mode is not supported by the {settings.StorageType} persister."); | |
| throw new InvalidOperationException($"Maintenance mode is not supported by the {settings.StorageType} storage type."); |
| @@ -76,7 +76,7 @@ public OkObjectResult Config() | |||
| }, | |||
| Persistence = new | |||
Contributor
There was a problem hiding this comment.
What consumes this endpoint and uses this value? Should we look into that and rename to Storage to match https://github.com/Particular/ServiceControl/pull/6077/changes#diff-0dac823f83eb2baf7a60865a0e0f69a28455224625a193cc769ce543c36fbe12R82 ?
Contributor
Author
There was a problem hiding this comment.
Possibly
I changed it back because I didn't want to upset SP but it looks like it's only consumed internally in SC
rbev
force-pushed
the
rename-persistencetype
branch
from
November 4, 2026 02:04
f6f8a46 to
ae65403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Targeted for 7.0, should not be merged to
masteruntil it is time to mark that branch for the major updateRename the Error and Audit instance storage setting to match the ServiceControl 7 documentation. Preserve the selected storage engine when the installer upgrades an existing instance.
Changes
StorageType.--persistenceoption to--storageand update its README, UI guidance, and load-testing documentation.Upgrade behavior
The installer reads
StorageTypefirst and falls back toPersistenceTypewhen the new setting is absent or blank. Configuration writes use the resolved persistence manifest to populateStorageType, preserving the selected engine rather than migrating data.The installer removes
PersistenceTypewhen the installed instance reaches version 7.0.0, including prereleases. Earlier instances retain the legacy key so their runtimes can continue reading it. This applies to both Error and Audit instances and covers configuration edits and configuration restoration after an upgrade.The runtime reads only
StorageType; the legacy fallback belongs to the installer. Manually managed configurations and environment variables usingPersistenceTypemust be renamed. The audit configuration API retains its existingpersistence.persistence_typeresponse field to avoid changing that public response shape.