Replace CombGuid with Guid.CreateVersion7 for message ID generation - #5839
Merged
Conversation
UUIDv7 is time-ordered and monotonically increasing, providing the same database-friendly ordering properties as the COMB algorithm without requiring a custom implementation. This removes the locally maintained CombGuid class in favour of the built-in .NET API.
johnsimons
commented
Sep 1, 2026
| var messageId = Guid.CreateVersion7().ToString("D"); | ||
| var headers = HeaderFilter.RemoveErrorMessageHeaders(message.NewHeaders); | ||
| corruptedReplyToHeaderStrategy.FixCorruptedReplyToHeader(headers); | ||
| headers[Headers.MessageId] = Guid.NewGuid().ToString("D"); |
Member
Author
There was a problem hiding this comment.
I also updated this, which was wrong!
johnsimons
enabled auto-merge
September 1, 2026 05:01
rbev
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UUIDv7 is time-ordered and monotonically increasing, providing the same database-friendly ordering properties as the COMB algorithm without requiring a custom implementation. This removes the locally maintained CombGuid class in favour of the built-in .NET API.