Skip to content

Fix digikey create from scan #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbtronics merged 4 commits into from
Sep 6, 2026
Merged

Fix digikey create from scan #1517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e890d9c
Don't urlencode the provider ID
d-buchmann Sep 2, 2026
2b03ac6
Prefer digikey part number if available
d-buchmann Sep 2, 2026
95c3a83
Use rawurlencode instead of urlencode, so that a space gets encoded a…
jbtronics Sep 6, 2026
c947240
Use rawurlencode in OEMSecretsProvider too
jbtronics Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Services/InfoProviderSystem/Providers/DigikeyProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function searchByKeyword(string $keyword, array $options = []): array
public function getDetails(string $id, array $options = []): PartDetailDTO
{
try {
$response = $this->digikeyClient->request('GET', '/products/v4/search/' . urlencode($id) . '/productdetails', [
$response = $this->digikeyClient->request('GET', '/products/v4/search/' . rawurlencode($id) . '/productdetails', [
'auth_bearer' => $this->authTokenManager->getAlwaysValidTokenString(self::OAUTH_APP_NAME)
]);
} catch (\InvalidArgumentException $exception) {
Expand Down Expand Up @@ -302,7 +302,7 @@ private function mediaToDTOs(string $id): array
$datasheets = [];
$images = [];

$response = $this->digikeyClient->request('GET', '/products/v4/search/' . urlencode($id) . '/media', [
$response = $this->digikeyClient->request('GET', '/products/v4/search/' . rawurlencode($id) . '/media', [
'auth_bearer' => $this->authTokenManager->getAlwaysValidTokenString(self::OAUTH_APP_NAME)
]);

Expand Down
2 changes: 1 addition & 1 deletion src/Services/InfoProviderSystem/Providers/OEMSecretsProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,7 +1249,7 @@ private function generateInquiryUrl(string $partNumber, string $oemInquiry = 'co
{
$baseUrl = rtrim($this->getProviderInfo()->url, '/') . '/';
$inquiryPath = trim($oemInquiry, '/') . '/';
$encodedPartNumber = urlencode(trim($partNumber));
$encodedPartNumber = rawurlencode(trim($partNumber));
return $baseUrl . $inquiryPath . $encodedPartNumber;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Services/LabelSystem/BarcodeScanner/BarcodeScanResultHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ private function getCreationInfoForEIGP114(EIGP114BarcodeScanResult $scanResult)
if ($vendor === 'digikey') {
return [
'providerKey' => 'digikey',
'providerId' => $scanResult->supplierPartNumber ?? throw new \RuntimeException('Digikey barcode does not contain required supplier part number'),
'providerId' => $scanResult->digikeyPartNumber ?? $scanResult->supplierPartNumber ?? throw new \RuntimeException('Digikey barcode does not contain required supplier part number'),
'lotAmount' => $scanResult->quantity,
'lotName' => $scanResult->digikeyInvoiceNumber ?? $scanResult->digikeySalesOrderNumber ?? $scanResult->customerPO,
'lotUserBarcode' => $scanResult->rawInput,
Expand Down