Support 0 Ω resistor values in the component image generator - #1515
Merged
Conversation
Entering "0" (or a 0R/0805 jumper part) was rejected everywhere the calculator checked `value > 0`, even though 0 Ω "jumper" resistors are a real, standard part. Zero is now accepted for the resistor and SMD resistor tabs and drawn with the conventional all-black bands / "000"/"0000" markings; the server-side ComponentValueGuesser now also classifies parts with a 0 Ω resistance parameter or "0R" name instead of silently skipping them. Also adds a 5 W resistor power-rating option, as requested in the same issue. Fixes #1508
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entering "0" (or a 0R/0805 jumper part) was rejected everywhere the
calculator checked
value > 0, even though 0 Ω "jumper" resistors area real, standard part. Zero is now accepted for the resistor and SMD
resistor tabs and drawn with the conventional all-black bands /
"000"/"0000" markings; the server-side ComponentValueGuesser now also
classifies parts with a 0 Ω resistance parameter or "0R" name instead
of silently skipping them. Also adds a 5 W resistor power-rating
option, as requested in the same issue.
Fixes #1508