Skip to content

Fix flaky/broken regression test for the "move to new part lot" fix #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbtronics merged 5 commits into from
Sep 1, 2026
Merged

Fix flaky/broken regression test for the "move to new part lot" fix #1514

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7767635
Fix DB error when creating a new part lot via withdraw/move form
claude Sep 1, 2026
3056230
Add regression test for moving stock to a newly created part lot
claude Sep 1, 2026
8cb030a
Fix SessionNotFoundException in new part lot regression test
claude Sep 1, 2026
3bc5633
Merge remote-tracking branch 'origin/master' into claude/part-lots-cr…
Copilot Sep 1, 2026
6a51fe3
Send comment field in new part lot regression test
claude Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/Controller/PartControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
use PHPUnit\Framework\Attributes\Group;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;

#[Group("slow")]
#[Group("DB")]
Expand Down Expand Up @@ -485,14 +484,19 @@ public function testWithdrawAddMoveToNewLotDoesNotThrow(): void
$partId = $part->getId();
$sourceLotId = $sourceLot->getId();

$csrfTokenManager = $client->getContainer()->get(CsrfTokenManagerInterface::class);
$token = $csrfTokenManager->getToken('part_withraw' . $partId)->getValue();
// Load the part page first, both to start a session (the CSRF token storage needs one)
// and to grab the real CSRF token the withdraw/move form would submit.
$crawler = $client->request('GET', "/en/part/{$partId}");
$this->assertResponseStatusCodeSame(Response::HTTP_OK);
$token = (string) $crawler->filter('input[name="_csfr"]')->first()->attr('value');

$client->request('POST', "/en/part/{$partId}/add_withdraw", [
'lot_id' => $sourceLotId,
'target_id' => 'new',
'amount' => '4',
'action' => 'move',
//The real form always submits this field (even when empty), so mirror that here
'comment' => '',
'part_lot' => [
'storage_location' => $storageLocation->getId(),
],
Expand Down