Skip to content

Fix PostgreSQL startup race in observability tests - #29

Merged
Eoic merged 1 commit into
developmentfrom
fix/postgres-test-readiness
Oct 21, 2026
Merged

Eoic merged 1 commit into
developmentfrom
fix/postgres-test-readiness

Conversation

@Eoic

@Eoic Eoic commented Oct 21, 2026

Copy link
Copy Markdown
Member

The PostgreSQL test fixture could treat the image's temporary initialization server as ready, then lose its connection when that server stopped. Wait for the final TCP listener and use TCP for fixture queries.

Delayed initialization now reproduces the premature-readiness failure before the fix. SQL setup failures also include their stderr in CI output.

Validation: the delayed fixture failed with the old check, then all 14 tests, native configuration validation, generated-file consistency, and git diff --check passed with the fix. Full Linux smoke checks run in CI.

Closes #28. Follow-up to TASK-OBS-05 / #20, covering NFR-9_2 (PapyrusReader/docs#80).

Copilot AI balanced review requested due to automatic review settings October 21, 2026 00:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T00:04:44.544999Z 2eaf34a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic merged commit c2aaf28 into development Oct 21, 2026
1 check passed
@Eoic
Eoic deleted the fix/postgres-test-readiness branch October 21, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix disposable PostgreSQL startup race in CI

2 participants