fix(world): complete session-end landmark purge in Growth render - #2
Closed
PabloTheThinker wants to merge 1 commit into
Closed
fix(world): complete session-end landmark purge in Growth render#2PabloTheThinker wants to merge 1 commit into
PabloTheThinker wants to merge 1 commit into
Conversation
Extract _clean_landmarks() helper used by leave(), add_landmark(), _render_landmarks(), and _render_growth(). Growth epoch summary was still reading raw landmarks and could show session-end spam counts. add_landmark() now purges legacy noise on every call, matching the intent of the recent landmark-spam fixes. Co-authored-by: Pablo <PabloTheThinker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the recent session-end landmark spam fixes on
main(commits00e7a80,a0fa9b4,aa8513e). Those changes stopped new generic session-end notes from becoming landmarks and cleaned them during Genesis/Maturity/Wisdom renders, but two gaps remained:_render_growth()bypassed cleanup — the Growth epoch summary read rawself._state.landmarks, so agents in the Growth epoch could still see inflated counts and "session ended" as oldest/most-recent landmark.add_landmark()did not purge legacy spam — the latest commit message said "purge on add and render", but only blocked new generic notes; existing session-end entries stayed in state until the nextleave()or Genesis render.Changes
_GENERIC_LEAVE_NOTESand_clean_landmarks()helper (filter + cap at 40).leave(),add_landmark(),_render_landmarks(), and_render_growth().tests/test_world.pycovering leave, add-landmark purge, and Growth render behavior.Test plan
PYTHONPATH=src python3 -m unittest discover -s tests -q(64 tests, OK)