Skip to content

PSModule no longer supplies a pull request template - #82

Merged
Marius Storhaug (MariusStorhaug) merged 5 commits into
mainfrom
psmodule-pr-defaults
Nov 4, 2026
Merged

Marius Storhaug (MariusStorhaug) merged 5 commits into
mainfrom
psmodule-pr-defaults

Conversation

@MariusStorhaug

@MariusStorhaug Marius Storhaug (MariusStorhaug) commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

PSModule no longer supplies an inherited pull request template. New pull requests in repositories that used the organization fallback no longer receive that scaffold; existing descriptions and repository-local templates are unchanged. No module code, configuration, workflow, runtime or installation changes are required.

Removed: Organization-default pull request template

The central .github/pull_request_template.md is deleted without a replacement. This PR makes no other file changes. README, contribution guidance, other community policies, issue forms and agent routes retain their existing contents.

For a new PR that relied on this fallback, write the description through the existing authoring entrypoints and verify it expresses the applicable result and consumer actions or a justified no-action outcome. There are no prerequisite installations, intermediate operations or consumer-code edits for this removal. The user's intended discovery path is repository AGENTS.md plus the PR-format skill, rather than additional documentation pointers. This PR does not add or verify that wiring across repositories.

Technical details

Exact scoped comparison: base f424237c98b5b020f80e8c9563dbc37256fc1ec0 to candidate 34fe1e90009a22c79b53edc6456c24a47f21fcfd contains one removed file, .github/pull_request_template.md, with 0 additions and 18 deletions. README and .github/CONTRIBUTING.md match actual current main byte-for-byte. Only the 3 README and 11 CONTRIBUTING lines previously added by this PR were removed; all pre-existing guidance and links are preserved.

Plan and history: all scoped implementation and current-source review steps in Task PSModule/.github#81 are complete. Earlier scaffold-distribution and extra-documentation requirements are superseded, not delivered; ordinary commits and comments retain their audit trail. No other repository, agent file, skill, workflow, test, dependency, linter or pre-commit configuration changed. No prose/source-shape assertions or validation pipeline were added for this deletion.

Changed surface Standards checked Framework docs checked Result
Deleted .github/pull_request_template.md Current Repository Standard no-PR-template-file policy; scoped contribution workflow and PR Format Organization-default distribution contract Aligned

Verification and review: the live GitHub diff confirms the single deletion. Git blob comparisons establish exact main-byte equality for both restored documents, and the complete pushed tree contains no replacement PR template. Working, staged and complete-range whitespace checks passed. The full head-bound review is APPROVED on 34fe1e90009a22c79b53edc6456c24a47f21fcfd and records no active issues. There are zero inline comments and zero unresolved threads; the shared review loop reports a clean round. GitHub reports reviewDecision: APPROVED and mergeStateStatus: CLEAN. No genuine review blocker is currently recorded, and no merge or new approving review was performed by this session.

Current prerequisites: the repository-only validator/linter delivery was withdrawn and pre-commit deferred. Issues #83, #84 and #85 are closed as not_planned, the old native dependency on #83 was removed with user approval, and ruleset 26275706 has an empty rules list. Those historical criteria are not blockers and this PR restores none of that work. This is not an MSX-wide standard change. MSXOrg/docs#209 is merged and is not a pending source dependency.

The scoped issue sweep covers Task #81 and the related deleted-template request; no additional issue is fully satisfied by this diff. Only Task #81 is a closing reference. This target has no Release Management or native versioned-artifact publication route, so the scoped diff supplies change coverage without an invented publication baseline, release label or Release decisions block.

GitHub auto-merge remains null, and existing Agent merge retains merge_pr: false; those settings were not changed. No label, protection, issue-state or native-relationship mutation is included. Merge and delivery closure remain separate from this verified revision.

Related references

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The governing scaffold in MSXOrg/docs#209 remains draft and merge-blocked, so source readiness and required CI/governance gates need maintainer confirmation before approval.

No open issues 🎉

What changed in this PR

Expands PSModule’s inherited pull request template into a complete, audience-first release-note scaffold for repositories without a local template. This is a documentation-only change; it does not alter release automation or runtime behavior.

Changes:

  • Adds five ordered result groups with adoption, compatibility, verification, and result-specific evidence prompts.
  • Clarifies announcement boundaries and conditional release decisions, including settings precedence and canonical labels.
  • Adds contribution guidance linking the inherited template and keeping release-specific upgrade instructions in PR descriptions and release notes.
File Description
.github/​pull_request_template.md Provides the complete release-note scaffold and conditional release authoring guidance.
.github/​CONTRIBUTING.md Links the inherited template and clarifies where consumer upgrade instructions belong.

Review effort: Balanced

@MariusStorhaug

Copy link
Copy Markdown
Member Author

Inspected the complete final-head review, including its summary. There are no code findings or inline threads. The summary calls out the draft governing source and required CI/governance confirmation; those remain real prerequisites, with the native validation/enforcement dependency tracked in #83. This PR stays draft. The successful review check is not substituted for an enforced file-validation gate, and no auto-merge or ruleset change is made.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Maintainer confirmation is needed because MSXOrg/docs#209 remains draft and unmerged, while #83 leaves required candidate-head validation and protection enforcement unresolved.

No open issues 🎉

Review effort: Balanced

@MariusStorhaug Marius Storhaug (MariusStorhaug) changed the title PSModule PR defaults include complete release-note guidance PSModule PR authors use canonical guidance without template files Oct 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The required exact-head Community file validation is missing, and pending canonical no-file guidance and separately owned validator integration require reconciliation and independent confirmation.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 4, 2026 08:07
@MariusStorhaug Marius Storhaug (MariusStorhaug) changed the title PSModule PR authors use canonical guidance without template files PSModule no longer supplies a pull request template Nov 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are recorded for the deletion of the organization-default pull request template.

No open issues 🎉

Review effort: Balanced

@MariusStorhaug
Marius Storhaug (MariusStorhaug) merged commit 4e0092d into main Nov 4, 2026
1 check passed
@MariusStorhaug
Marius Storhaug (MariusStorhaug) deleted the psmodule-pr-defaults branch November 4, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove only the PSModule pull request template

2 participants