Skip to content

Release 3.6.2#153

Open
snehar-nd wants to merge 61 commits into
mainfrom
release-3.6.2
Open

Release 3.6.2#153
snehar-nd wants to merge 61 commits into
mainfrom
release-3.6.2

Merge pull request #152 from PSMRI/sn/duplicate

799a627
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 25, 2026 in 1m 15s

Quality Gate failed

Failed conditions
14.0% Duplication on New Code (required ≤ 3%)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 58 in src/main/java/com/iemr/tm/controller/login/IemrMmuLoginController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK8EC8HypAW_98Zz&open=AZ79SK8EC8HypAW_98Zz&pullRequest=153

Check warning on line 41 in src/main/java/com/iemr/tm/utils/mapper/RoleAuthenticationFilter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SLDTC8HypAW_98Z-&open=AZ79SLDTC8HypAW_98Z-&pullRequest=153

Check failure on line 32 in src/main/java/com/iemr/tm/utils/mapper/RoleAuthenticationFilter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"logger" is the name of a field in "GenericFilterBean". 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SLDTC8HypAW_98Z7&open=AZ79SLDTC8HypAW_98Z7&pullRequest=153

Check failure on line 193 in src/main/java/com/iemr/tm/service/common/transaction/CommonDoctorServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SKynC8HypAW_98Zt&open=AZ79SKynC8HypAW_98Zt&pullRequest=153

Check warning on line 566 in src/main/java/com/iemr/tm/service/common/transaction/CommonServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SKvmC8HypAW_98Zp&open=AZ79SKvmC8HypAW_98Zp&pullRequest=153

Check warning on line 305 in src/main/java/com/iemr/tm/service/benFlowStatus/CommonBenStatusFlowServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK2XC8HypAW_98Zv&open=AZ79SK2XC8HypAW_98Zv&pullRequest=153

Check warning on line 576 in src/main/java/com/iemr/tm/service/common/transaction/CommonServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SKvmC8HypAW_98Zr&open=AZ79SKvmC8HypAW_98Zr&pullRequest=153

Check warning on line 48 in src/main/java/com/iemr/tm/utils/IntegerListConverter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty collection instead of null. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SLDrC8HypAW_98Z_&open=AZ79SLDrC8HypAW_98Z_&pullRequest=153

Check warning on line 58 in src/main/java/com/iemr/tm/controller/teleconsultation/TeleConsultationController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK6fC8HypAW_98Zx&open=AZ79SK6fC8HypAW_98Zx&pullRequest=153

Check warning on line 53 in src/main/java/com/iemr/tm/controller/videoconsultationcontroller/VideoConsultationController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK7xC8HypAW_98Zy&open=AZ79SK7xC8HypAW_98Zy&pullRequest=153

Check warning on line 132 in src/main/java/com/iemr/tm/controller/login/IemrMmuLoginController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not log user-controlled data. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK8EC8HypAW_98Z0&open=AZ79SK8EC8HypAW_98Z0&pullRequest=153

Check warning on line 567 in src/main/java/com/iemr/tm/service/common/transaction/CommonServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SKvmC8HypAW_98Zq&open=AZ79SKvmC8HypAW_98Zq&pullRequest=153

Check warning on line 24 in src/main/java/com/iemr/tm/utils/StringListConverter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.util.Arrays'. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SLHuC8HypAW_98aB&open=AZ79SLHuC8HypAW_98aB&pullRequest=153

Check warning on line 30 in src/main/java/com/iemr/tm/service/benFlowStatus/CommonBenStatusFlowServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.checkerframework.checker.units.qual.s'. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK2XC8HypAW_98Zw&open=AZ79SK2XC8HypAW_98Zw&pullRequest=153

Check warning on line 38 in src/main/java/com/iemr/tm/utils/mapper/RoleAuthenticationFilter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SLDTC8HypAW_98Z9&open=AZ79SLDTC8HypAW_98Z9&pullRequest=153

Check warning on line 114 in src/main/java/com/iemr/tm/controller/common/master/CommonMasterController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK9PC8HypAW_98Z2&open=AZ79SK9PC8HypAW_98Z2&pullRequest=153

Check warning on line 583 in src/main/java/com/iemr/tm/service/common/transaction/CommonServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof JSONObject dataObj' 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SKvmC8HypAW_98Zs&open=AZ79SKvmC8HypAW_98Zs&pullRequest=153

Check warning on line 114 in src/main/java/com/iemr/tm/controller/common/master/CommonMasterController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK9PC8HypAW_98Z3&open=AZ79SK9PC8HypAW_98Z3&pullRequest=153

Check warning on line 35 in src/main/java/com/iemr/tm/utils/mapper/RoleAuthenticationFilter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SLDTC8HypAW_98Z8&open=AZ79SLDTC8HypAW_98Z8&pullRequest=153

Check warning on line 82 in src/main/java/com/iemr/tm/controller/login/IemrMmuLoginController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not log user-controlled data. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK8EC8HypAW_98Z1&open=AZ79SK8EC8HypAW_98Z1&pullRequest=153

Check failure on line 39 in src/main/java/com/iemr/tm/utils/mapper/SecurityConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure disabling Spring Security's CSRF protection is safe here. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SLDEC8HypAW_98Z6&open=AZ79SLDEC8HypAW_98Z6&pullRequest=153

Check warning on line 567 in src/main/java/com/iemr/tm/service/common/transaction/CommonServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SKvmC8HypAW_98Zo&open=AZ79SKvmC8HypAW_98Zo&pullRequest=153

Check warning on line 119 in src/main/java/com/iemr/tm/utils/redis/RedisStorage.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty collection instead of null. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SLC3C8HypAW_98Z5&open=AZ79SLC3C8HypAW_98Z5&pullRequest=153

Check warning on line 283 in src/main/java/com/iemr/tm/service/benFlowStatus/CommonBenStatusFlowServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SK2XC8HypAW_98Zu&open=AZ79SK2XC8HypAW_98Zu&pullRequest=153

Check warning on line 99 in src/main/java/com/iemr/tm/utils/redis/RedisStorage.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=PSMRI_TM-API&issues=AZ79SLC3C8HypAW_98Z4&open=AZ79SLC3C8HypAW_98Z4&pullRequest=153
View more details on SonarQubeCloud