Release 3.8.2 to main by snehar-nd · Pull Request #438 · PSMRI/Common-API

snehar-nd · 2026-06-30T11:42:01Z

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.

✅ Type of Change

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

add bengali language translation on dynamic forms

…ease-3.8.2

* fix: aam-2313 phone number leading with zero - removed zero * fix: allow concurrent sessions for admin, superadmin, and supervisor roles Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: added admin and superadmin for the condition --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

…ession logout redisTemplate has Jackson2JsonRedisSerializer<User> as value serializer, so reading the plain-string jti: value caused a deserialization failure (statusCode 5000). jti: keys are written via stringRedisTemplate at login, so reads and deletes must also use stringRedisTemplate — restoring the behaviour from commit 80fa0e5 that was accidentally reverted in #423. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Fix role name from 'admin' to 'provideradmin' to match actual DB value - Add concurrent session exemption to superUserAuthenticate so SuperAdmin can log in from multiple tabs without being blocked Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: use stringRedisTemplate for jti: key read/delete in concurrent session

…ssword Feature/handel multiple attempt password

Redis keys were stored on MMU login with 30-day TTL but never deleted on logout. Added cleanup in userLogout() so stale camp config does not persist after the MMU session ends. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Lets a device on the same network discover the API's LAN IP and port without needing it typed in manually, and bumps version to 3.8.2.

Sn/token expiry

fix issue of feature multiple login attempt

Fix login issue multiple login

….8.2

….8.2 # Conflicts: # src/main/java/com/iemr/common/service/users/IEMRAdminUserService.java # src/main/java/com/iemr/common/service/users/IEMRAdminUserServiceImpl.java

Merge release-3.8.1, main ti release-3.8.2

Saurav's PR #431 added a "Remaining attempts: N" message on failed login to warn users before account lockout. Port this into the refactored handleFailedLoginAttempt helper so both userAuthenticate and superUserAuthenticate keep the behavior after merging release-3.8.1's account-lock refactor into release-3.8.2.

….8.2

The merge of release-3.8.1's account-lock refactor into release-3.8.2 replaced Saurav Mishra's inline multiple-login-attempt logic (PR #426/#431/#432) with the refactored handlePasswordValidationAndLocking helper. The refactor kept the "Remaining attempts" warning but dropped the final lockout message text, falling back to the unrelated generateLockoutErrorMessage used for already-locked accounts. Restore the exact lockout message from PR #432 so the refactored helper preserves both branches' intended behavior.

Merging #431 commit

Co-authored-by: Sneha <sneha@ADMINs-MacBook-Pro.local>

coderabbitai · 2026-06-30T11:42:33Z

Warning

Review limit reached

@snehar-nd, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b3acc939-27a4-474d-9691-1ae7115b61d1

📥 Commits

Reviewing files that changed from the base of the PR and between 3773e26 and d2efa54.

📒 Files selected for processing (12)

pom.xml
src/main/java/com/iemr/common/controller/connect/ConnectController.java
src/main/java/com/iemr/common/controller/users/IEMRAdminController.java
src/main/java/com/iemr/common/data/dynamic_from/FormFieldOption.java
src/main/java/com/iemr/common/data/translation/Translation.java
src/main/java/com/iemr/common/service/dynamicForm/FormMasterServiceImpl.java
src/main/java/com/iemr/common/service/users/IEMRAdminUserService.java
src/main/java/com/iemr/common/service/users/IEMRAdminUserServiceImpl.java
src/main/java/com/iemr/common/utils/CookieUtil.java
src/main/java/com/iemr/common/utils/JwtUserIdValidationFilter.java
src/main/java/com/iemr/common/utils/NetworkUtil.java
src/main/resources/application.properties

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

sonarqubecloud · 2026-06-30T11:43:03Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

+
+	public static String getLanIPAddress() {
+		try (DatagramSocket socket = new DatagramSocket()) {
+			socket.connect(InetAddress.getByName("8.8.8.8"), 10002);


SauravBizbRolly and others added 30 commits May 6, 2026 12:18

add bengali language translation on dynamic forms

3c5b5b8

Merge pull request #406 from PSMRI/feature/add_bengali_language

eb9de55

add bengali language translation on dynamic forms

Merge remote-tracking branch 'upstream/vbb/release-3.8.1' into sm/rel…

2cd890c

…ease-3.8.2

change api version

bc54def

Merge pull request #424 from PSMRI/vb/fixSession

a8102b1

fix: use stringRedisTemplate for jti: key read/delete in concurrent session

Implement feature multiple login attempt

2c23d93

Implement feature multiple login attempt

fe3336a

Merge pull request #426 from PSMRI/feature/handel_multiple_attempt_pa…

5424887

…ssword Feature/handel multiple attempt password

feat: add endpoint to expose server's LAN IP address

758bf36

Lets a device on the same network discover the API's LAN IP and port without needing it typed in manually, and bumps version to 3.8.2.

fix: extented the token expiry timing

be92d7c

Merge pull request #428 from PSMRI/sn/tokenExpiry

fc1deba

Sn/token expiry

fix issue of feature multiple login attempt

e04714b

Merge pull request #431 from PSMRI/fix_multiple_login_issue

fee73b3

fix issue of feature multiple login attempt

fix issue of feature multiple login attempt

818257c

fix issue of feature multiple login attempt

a27db85

Merge pull request #432 from PSMRI/fix_login_issue_multiple_login

38e4c02

Fix login issue multiple login

Merge remote-tracking branch 'origin/main' into vb/release-3.8.2

73caab7

Merge remote-tracking branch 'origin/release-3.8.1' into vb/release-3…

d08403f

….8.2

Merge remote-tracking branch 'origin/release-3.8.2' into vb/release-3…

5a34772

….8.2 # Conflicts: # src/main/java/com/iemr/common/service/users/IEMRAdminUserService.java # src/main/java/com/iemr/common/service/users/IEMRAdminUserServiceImpl.java

Merge pull request #434 from PSMRI/vb/release-3.8.2

c9a2694

Merge release-3.8.1, main ti release-3.8.2

Increase timing of refresh token (#435)

c3013e0

Merge remote-tracking branch 'origin/release-3.8.2' into vb/release-3…

8743f34

….8.2

Merge pull request #436 from PSMRI/vb/release-3.8.2

89d1da2

Merging #431 commit

fix: AMM-2343 on lock/Unlock the api was returning 500 error (#437)

d2efa54

Co-authored-by: Sneha <sneha@ADMINs-MacBook-Pro.local>

github-advanced-security AI found potential problems Jun 30, 2026

View reviewed changes

Comment thread src/main/java/com/iemr/common/utils/NetworkUtil.java

public static String getLanIPAddress() {

try (DatagramSocket socket = new DatagramSocket()) {

socket.connect(InetAddress.getByName("8.8.8.8"), 10002);

vanitha1822 approved these changes Jun 30, 2026

View reviewed changes

vishwab1 approved these changes Jul 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release 3.8.2 to main#438

Release 3.8.2 to main#438
snehar-nd wants to merge 30 commits into
mainfrom
release-3.8.2

snehar-nd commented Jun 30, 2026

Uh oh!

coderabbitai Bot commented Jun 30, 2026

Review limit reached

Uh oh!

sonarqubecloud Bot commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

snehar-nd commented Jun 30, 2026

📋 Description

✅ Type of Change

ℹ️ Additional Information

Uh oh!

coderabbitai Bot commented Jun 30, 2026

Review limit reached

Uh oh!

sonarqubecloud Bot commented Jun 30, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants