Make disabling formatting explicit - #421
Open
enwi wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@AJenbo If for whatever reason you think this should be implemented differently, just go for it. This is just a temporary fix for our project. |
calebdw
requested changes
Sep 2, 2026
Comment on lines
+306
to
+307
| /// Explicitly disable all formatting | ||
| pub disabled: Option<bool>, |
Collaborator
There was a problem hiding this comment.
disabledresults in a double negative which is confusing---would rather the option be namedenabledwhich is true by default- the config schema needs to be updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current version it is not possible to explicitly disable external & auto found formatters while still being able to use the internal mago fallback. This PR adds an explicit flag to disable formatting entirely, removing the previous check when all tools are disabled.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,examples/)config-schema.json)how it works, how it's organized), including any code drafted by an LLM.