Skip to content

Make disabling formatting explicit - #421

Open
enwi wants to merge 1 commit into
PHPantom-dev:mainfrom
enwi:fix-disabled-formatters
Open

Make disabling formatting explicit#421
enwi wants to merge 1 commit into
PHPantom-dev:mainfrom
enwi:fix-disabled-formatters

Conversation

@enwi

@enwi enwi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

With the current version it is not possible to explicitly disable external & auto found formatters while still being able to use the internal mago fallback. This PR adds an explicit flag to disable formatting entirely, removing the previous check when all tools are disabled.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, examples/)
  • I have updated the config schema (config-schema.json)
  • I have added/updated tests to cover my changes
  • I fully understand the code that I am submitting (what it does,
    how it works, how it's organized), including any code drafted by an LLM.

@enwi

enwi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@AJenbo If for whatever reason you think this should be implemented differently, just go for it. This is just a temporary fix for our project.

Comment thread src/config.rs
Comment on lines +306 to +307
/// Explicitly disable all formatting
pub disabled: Option<bool>,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • disabled results in a double negative which is confusing---would rather the option be named enabled which is true by default
  • the config schema needs to be updated

@AJenbo AJenbo added this to the Sprint 7 milestone Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants