Skip to content

fix(indexing): keep resource startup progress moving - #408

Open
sidux wants to merge 17 commits into
PHPantom-dev:mainfrom
sidux:fix/indexing-resource-startup-progress
Open

fix(indexing): keep resource startup progress moving#408
sidux wants to merge 17 commits into
PHPantom-dev:mainfrom
sidux:fix/indexing-resource-startup-progress

Conversation

@sidux

@sidux sidux commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • count autoload files only after parsing finishes
  • give framework resource discovery and indexing a visible, counted startup phase
  • build one line-offset index per resource instead of rescanning from the start for every match

Why

Startup could appear frozen while expensive work continued behind a percentage that no longer described the active phase. Large configuration files also paid repeatedly to convert byte offsets into line and column positions. Reporting completed work and reusing one line index makes progress smoother and removes avoidable repeated scanning.

Dependencies

Validation

  • cargo test --all-targets on this branch and its semantic-indexing successor
  • cargo clippy --fix --allow-dirty -- -D warnings
  • cargo fmt

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 88.90972% with 710 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/code_lens.rs 88.14% 131 Missing ⚠️
src/completion/symfony.rs 85.45% 105 Missing ⚠️
src/symfony/container.rs 74.69% 104 Missing ⚠️
src/rename/prepare.rs 55.78% 65 Missing ⚠️
src/indexing/watch.rs 47.78% 59 Missing ⚠️
src/symfony/events.rs 93.90% 50 Missing ⚠️
src/symfony/expressions.rs 93.00% 45 Missing ⚠️
src/references/dispatch.rs 66.29% 30 Missing ⚠️
src/proxy_metadata.rs 92.13% 25 Missing ⚠️
src/references/members.rs 94.19% 25 Missing ⚠️
... and 10 more

📢 Thoughts on this report? Let us know!

sidux added 7 commits August 30, 2026 17:12
Use the coarse reference index for conclusive zero counts and cache bounded exact member locations for non-zero lenses. Refresh-capable clients avoid eager resolve storms while older clients retain lazy resolution.
Stop reference counts and CodeLens resolves from repeating the full workspace walk for every declaration. Internal annotation requests share the initial index, including callers queued behind it, while an explicit Find References command keeps its single refresh for files created without watcher notifications.
@sidux
sidux force-pushed the fix/indexing-resource-startup-progress branch from 5b1be6f to e561797 Compare August 30, 2026 15:33
sidux added 10 commits August 30, 2026 17:40
Resolve fully-qualified classes and Class::member references from arbitrary YAML and XML positions without schema-specific rules.
Feed schema-free class and member occurrences into Find References and CodeLens, including transparent-proxy metadata aliases.
Index semantic framework relationships alongside generic YAML and XML class references.
Pass every indexed target to editor-native navigation and ignore empty PHP resource strings.
Generic YAML and XML navigation now returns early only when it resolves a PHP symbol. Otherwise the semantic Symfony resolver still handles aliases, form fields, validation mappings, and configuration keys.
Build entity-to-repository pairs alongside the framework resource index and update them per URI. CodeLens and reference lookups now read the derived index instead of reopening and rescanning every YAML/XML resource for each declaration.
@sidux
sidux force-pushed the fix/indexing-resource-startup-progress branch from e561797 to 7370ea9 Compare August 30, 2026 15:54
@sidux sidux mentioned this pull request Aug 30, 2026
6 tasks
@AJenbo AJenbo added this to the Sprint 8 milestone Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants