Skip to content

fix(indexing): canonicalize vendor scan paths - #407

Open
sidux wants to merge 1 commit into
PHPantom-dev:mainfrom
sidux:fix/vendor-scan-path-canonicalization
Open

fix(indexing): canonicalize vendor scan paths#407
sidux wants to merge 1 commit into
PHPantom-dev:mainfrom
sidux:fix/vendor-scan-path-canonicalization

Conversation

@sidux

@sidux sidux commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • retain both configured and canonical spellings of vendor directories
  • classify classes reached through filesystem aliases as dependency code
  • purge stale vendor functions and constants through either path spelling during Composer rescans
  • cover aliased vendor registration, rescans, and origin classification with Unix regression tests

Why

Workspace walkers and Composer discovery can observe the same directory through different filesystem spellings, especially where the operating system exposes path aliases. Comparing only the configured spelling makes dependency files look like project files, so indexing can enter the vendor tree, do far more work than expected, and distort completion ranking. Normalizing both forms keeps the exclusion and provenance rules consistent.

Validation

  • 3 focused vendor-path alias tests passed
  • cargo clippy --fix --allow-dirty -- -D warnings
  • cargo fmt
  • cargo clippy --all-targets -- -D warnings
  • cargo test — 14,102 passed, 12 ignored

@codecov-commenter

codecov-commenter commented Aug 27, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/indexing/scan.rs 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@sidux
sidux force-pushed the fix/vendor-scan-path-canonicalization branch 2 times, most recently from 9c7cadd to 2911e77 Compare August 30, 2026 15:54
@sidux sidux mentioned this pull request Aug 30, 2026
6 tasks
@sidux
sidux force-pushed the fix/vendor-scan-path-canonicalization branch from 2911e77 to 3b5cd13 Compare August 30, 2026 16:28
@AJenbo AJenbo added this to the Sprint 7 milestone Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants