feat(php): add implementation CodeLens - #393
Open
sidux wants to merge 2 commits into
Open
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
sidux
force-pushed
the
feat/php-implementation-lenses
branch
from
August 30, 2026 15:32
9617693 to
40f2958
Compare
Share exact implementation locations across navigation and lenses, including concrete members supplied by traits or inherited from parent classes.
Show exact class and method implementation targets after indexing, including inherited and trait-provided members.
sidux
force-pushed
the
feat/php-implementation-lenses
branch
from
August 30, 2026 15:53
40f2958 to
15d502f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Go to implementation already knows how to find descendants, but that capability is hard to discover from a declaration. Inherited and trait-provided implementations also need the same exact resolution path instead of a second approximation.
Summary
Validation