Require workspace refresh support before enabling pull diagnostics - #391
Closed
lcroberts wants to merge 1 commit into
Closed
Require workspace refresh support before enabling pull diagnostics#391lcroberts wants to merge 1 commit into
lcroberts wants to merge 1 commit into
Conversation
Collaborator
|
This is not the correct solution, neovim had a bug in its implementation and that doesn't mean that we need to support such a case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only negotiate and enable pull diagnostics (
textDocument/diagnostic) when the client explicitly advertisesworkspace.diagnostic.refreshSupport. Clients that advertise pull diagnostics without refresh support (e.g. Neovim ≤ 0.11)now fall back to standard push diagnostics (
textDocument/publishDiagnostics).I originally noticed this issue when using the LSP with a slightly older version of neovim. I would occasionally have stale diagnostics that stuck around until I edited the line.
Checklist
If applicable:
CHANGELOG.mdI have updated the documentation (README.md,docs/,examples/)I have updated the config schema (config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.