Repository navigation
NexDrop Phase 2.1: complete official artwork in launcher icons (wordmark + tagline preserved) - #3
Merged
Merged
Conversation
Root cause: the Phase 2 launcher generation extracted only the symbol band (rows 191-801) of the official artwork for the launcher foreground, so the NexDrop wordmark (rows 836-994) and the PRIVATE. DIRECT. FAST. tagline (rows 1008-1035) never entered the launcher resources. Fix: all 5 adaptive foregrounds are regenerated from the COMPLETE master artwork (content 963x847 = symbol + wordmark + tagline), scaled so the content bounding-box diagonal fits the 66/108 safe circle and centered — no crop, no distortion, artwork's own white background. Same treatment for the PWA set (192/512/apple-touch = whole artwork, maskable-512 diagonal-safe, favicon embeds the artwork raster). - branding suite rewritten with a dependency-free PNG pixel decoder: real content-bbox geometry (safe circle, centering), a wordmark/ tagline presence proof via full-composition aspect ratio (0.84-0.92; the rejected symbol-only 0.634 cannot pass), and pinned fingerprints (46 checks) - version 1.4.5 (18) -> 1.4.6 (19) - package/applicationId, signing, protocol code: untouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NexDrop Phase 2.1 — complete official artwork in the launcher icon
Root cause: Phase 2's launcher generation extracted only the symbol band (artwork rows 191–801) of the official master. The wordmark (rows 836–994) and the PRIVATE. DIRECT. FAST. tagline (rows 1008–1035) never entered the launcher resources — not lost in the build, never included.
Fix (from the master artwork, byte-identical to the re-supplied source):
Regression suite rewritten (46 checks): dependency-free PNG pixel decoder now measures the actual content bbox of every foreground: safe-circle geometry, centering, and a wordmark/tagline presence proof — content aspect must be in the full-composition range (~0.88); the rejected symbol-only foreground (~0.63) can never pass. Old-artwork fingerprints pinned.
Verified:
npm testfull chain PASS (all suites + 46 branding checks),tscPASS,eslintPASS. Package ID, signing config, and protocol code untouched.Known honest limitation: at real launcher sizes the complete artwork renders small (tagline ~1–2px, wordmark ~3–5px at 48–108px icons) — present, uncropped, but not legible. This is inherent to fitting a stacked three-element logo inside the maskable area; reported per the approval gate, not solved by cropping.
Approval requested: merge → triggers the production signed build + release.