Skip to content

chore: update vendored anti-slop to c44ef22 - #6

Merged
P-Theo merged 1 commit into
mainfrom
chore/update-anti-slop
Sep 10, 2026
Merged

P-Theo merged 1 commit into
mainfrom
chore/update-anti-slop

Conversation

@P-Theo

@P-Theo P-Theo commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Summary

Update the vendored anti-slop plugin from upstream e8100a1 to c44ef22 following the install-anti-slop update procedure.

  • Replace tools/oxlint/anti-slop/ with the verified upstream snapshot: updated rules/shared helpers, 3 new rules, the opt-in Effect plugin source, and the vendored eslint-stylistic spacing helpers with their license/provenance.
  • Add a minimal tools/oxlint/anti-slop/UPSTREAM.md recording the previous base (e8100a1), the adopted baseline (c44ef22), and the Effect-not-registered decision.
  • Enable anti-slop/no-array-filter-map, anti-slop/no-reduce-accumulator-copy, anti-slop/require-readable-spacing, and native oxc/no-accumulating-spread at error.
  • Fix the resulting 134 require-readable-spacing findings in project sources (blank-line-only autofix).
  • The Effect plugin is copied but intentionally not registered: this repository has no direct effect dependency.

Verification

  • Vendored base e8100a10da49858cfa8d26883d170e9cc8281988 confirmed pristine before replacement; staged incoming confirmed byte-identical to upstream c44ef22ca116d0ba62a3ff663a0bd13a3f3fa40b.
  • npx oxlint: 134 errors before, 0 after; a second --fix pass is a no-op.
  • npx tsc --noEmit: passes.
  • bun test: 61 pass / 0 fail.
  • CLI smoke test on the live plugin: all four new rules detect their patterns; the spacing autofix is stable and blank-line-only.
  • No dependency changes; oxlint and @oxlint/plugins remain paired at 1.78.0 (upstream's own pin).

Adopt the upstream snapshot in full: readable-spacing, array/reduce performance rules, Effect plugin source (unregistered), and vendored eslint-stylistic spacing helpers.

Enable the four new rules at error and apply the readable-spacing autofix to project sources (blank-line-only changes).

No dependency changes; oxlint and @oxlint/plugins stay paired at 1.78.0.
@P-Theo
P-Theo merged commit d113147 into main Sep 10, 2026
1 check passed
@P-Theo
P-Theo deleted the chore/update-anti-slop branch September 10, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant