[CHORE] Drop unused __about__.py files from Python packages#551
Draft
Seth Fitzsimmons (sethfitz) wants to merge 1 commit into
Draft
Conversation
PR #534 moved package versions to static declarations in pyproject.toml and reduced __about__.py to thin shims that derive __version__ from importlib.metadata. Nothing in packages/, .github/, or the Makefile references __about__ or __version__, so the shims are dead code. Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
Collaborator
Author
|
The failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #549.
Deletes the 12
__about__.pyversion shims. #534 (the base of this PR) already moved every package to a staticversionin pyproject.toml and rewrote the shims to read importlib.metadata; nothing references__about__or__version__anywhere in the tree (verified across packages/, .github/, and the Makefile).Targets #534's branch because the change builds on its version rework; retarget to main once #534 merges.