fix: answer a created public link with the hash that is its URL

src/Infrastructure/Adapter/In/Api/Controllers/PublicLink/CreateController.php

@@ -39,6 +39,12 @@ public function createAction(): ApiResponse
         $linkData = $linkData->mutate(
             [
                 'id' => $id,
+                // The hash is the link. `account/viewLink/{hash}` is the URL that gets handed out,
+                // and the service mints it, so a caller who had only what they sent could not
+                // hand out what they had just created — they had to fetch the link back to find
+                // out. That fetch answers with `data` as well, the sealed vault, so the way round
+                // the omission gave out more than this does.
+                'hash' => $stored->getHash(),
                 'dateExpire' => $stored->getDateExpire(),
                 'maxCountViews' => $stored->getMaxCountViews(),
             ]

tests/Integration/Infrastructure/Adapter/In/Api/Controllers/PublicLinkControllerTest.php

@@ -105,6 +105,36 @@ public function testTheExpiryAndViewLimitComeFromTheConfigurationNotTheCaller():
         );
     }
 
+    /**
+     * Creating a link answers with the link.
+     *
+     * `account/viewLink/{hash}` is the URL that gets handed out, and the service mints the hash,
+     * so a caller who had only what they sent back could not hand out what they had just made.
+     * The way round it was to fetch the link again — which answers with `data`, the sealed vault,
+     * so working around the omission gave out more than reporting the hash does.
+     *
+     * Both halves are asserted: the hash is there and is the one stored, and `data` is still not.
+     */
+    public function testCreatingALinkAnswersWithTheHashThatIsTheUrl(): void
+    {
+        $r = $this->createLink();
+
+        $this->assertSame(201, $r->status);
+        $this->assertNotEmpty($r->body->data->hash, 'without the hash the caller cannot build the URL');
+
+        $statement = getDbHandler()->getConnection()
+                                   ->prepare('SELECT `hash` FROM `PublicLink` WHERE `id` = :id');
+        $statement->execute(['id' => $r->body->itemId]);
+
+        $this->assertSame(
+            $statement->fetchColumn(),
+            $r->body->data->hash,
+            'the hash reported must be the one the link is stored under'
+        );
+
+        $this->assertNull($r->body->data->data, 'creating a link must not hand back the sealed vault');
+    }
+
     /**
      * The expiry and the view limit as the row holds them.
      *