Fix create - #134
Merged
0xisk merged 11 commits intoJul 29, 2026
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base
createforced a fixed param shape and a generic return, so subclass overrides fail ts static-side checks. This PR makescreatemore permissive. Without doing a heavy refactor of typechecking, the evidence that this fix works is in the simulators inintegration/. Without the fix, there's an ide error. With the fix, no errorSummary by CodeRabbit