Remove stale SignerManager

[andrew-fleming]

Summary by CodeRabbit

• Changed
  • Consolidated multisignature signer management under the unified Signer component.
  • Updated shielded multisignature presets to use the new signer interface.
  • Refined signer-related validation and error messages.
• Tests
  • Updated multisignature test expectations for the revised signer messages.
  • Removed obsolete standalone signer-manager test utilities and coverage.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 14b096bf-bf3d-4fb7-adae-cd4a0ccd62d3

📥 Commits

Reviewing files that changed from the base of the PR and between 6e4f497 and f1c6f33.

📒 Files selected for processing (10)

• CHANGELOG.md
• contracts/src/multisig/Signer.compact
• contracts/src/multisig/SignerManager.compact
• contracts/src/multisig/presets/ShieldedMultiSig.compact
• contracts/src/multisig/presets/ShieldedMultiSigV2.compact
• contracts/src/multisig/test/ShieldedMultiSig.test.ts
• contracts/src/multisig/test/ShieldedMultiSigV2.test.ts
• contracts/src/multisig/test/SignerManager.test.ts
• contracts/src/multisig/test/mocks/MockSignerManager.compact
• contracts/src/multisig/test/simulators/SignerManagerSimulator.ts

💤 Files with no reviewable changes (4)

• contracts/src/multisig/SignerManager.compact
• contracts/src/multisig/test/SignerManager.test.ts
• contracts/src/multisig/test/mocks/MockSignerManager.compact
• contracts/src/multisig/test/simulators/SignerManagerSimulator.ts

---

Walkthrough

Multisig presets now import Signer instead of SignerManager. The SignerManager module and related mocks, simulator, and tests are removed. Signer metadata, error-message expectations, interface documentation, and the changelog are updated.

Changes

Multisig signer consolidation

Layer / File(s)	Summary
Signer consolidation and preset wiring contracts/src/multisig/Signer.compact, contracts/src/multisig/SignerManager.compact, contracts/src/multisig/presets/*, contracts/src/multisig/test/mocks/MockSignerManager.compact, contracts/src/multisig/test/simulators/SignerManagerSimulator.ts, contracts/src/multisig/test/SignerManager.test.ts, CHANGELOG.md	Signer metadata and preset references are updated, while the SignerManager implementation and associated test artifacts are removed.
Validation error expectations contracts/src/multisig/test/ShieldedMultiSig.test.ts, contracts/src/multisig/test/ShieldedMultiSigV2.test.ts	Tests now expect Signer-prefixed validation and threshold errors.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related issues

• Issue 619 — Directly concerns consolidation of the multisig signer modules and related imports and error strings.

Possibly related PRs

• OpenZeppelin/compact-contracts#378 — Directly overlaps the removal of SignerManager artifacts and migration to Signer.
• OpenZeppelin/compact-contracts#424 — Introduces the Signer module used by this migration.
• OpenZeppelin/compact-contracts#594 — Directly overlaps the SignerManager module and supporting artifacts.

Suggested reviewers: 0xisk

Poem

A rabbit hops where signers meet,
Signer makes the path complete.
Old manager files fade away,
New error words now clearly say.
Thump, thump—multisig’s tidy today!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing the stale SignerManager module and related references.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[pepebndc]

LGTM. Clean consolidation, nice net deletion. Following up on a couple of small things over Slack.