Skip to content

chore: merge main into post-release - #595

Merged
0xisk merged 40 commits into
post-releasefrom
chore/sync-main-into-post-release
Jun 15, 2026
Merged

chore: merge main into post-release#595
0xisk merged 40 commits into
post-releasefrom
chore/sync-main-into-post-release

Conversation

@0xisk

@0xisk 0xisk commented Jun 15, 2026

Copy link
Copy Markdown
Member

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Maintenance / branch sync. This PR targets post-release, not main.

Merges the current main into post-release so the multisig suite can be migrated cleanly. After this lands, the post-release → main PR (#594) becomes conflict-free and mergeable while keeping Andrew's original commit history.

Why

main has advanced since post-release branched (0.1.0 / 0.2.0 releases, per-module Initializable split #562, pksk refactor, witness relocation #528). A direct post-release → main merge therefore conflicts in shared infra files. This PR resolves those conflicts on the post-release side.

Conflicts resolved

The multisig modules do not conflict — they import only other multisig modules plus the Compact standard library. Resolution kept main's conventions and preserved the multisig additions:

  • .gitignore, CHANGELOG.md: keep both sides' entries.
  • contracts/package.json: keep main's hierarchical build + SKIP_ZK test scripts and modern dependency versions; re-add fast-check.
  • contracts/vitest.config.ts: keep main's per-.ts 95% coverage gate.
  • contracts/src/utils/test/utils.test.ts: keep all describe blocks.
  • yarn.lock: regenerated via yarn install.

All 21 multisig .compact modules and the utils additions compile cleanly on the merged tree.

Unblocks #594.

PR Checklist

Further comments

No source behaviour changes — this is purely a merge/conflict resolution to prepare post-release for migration. Tests and docs come with the already-reviewed feature commits.

dependabot Bot and others added 30 commits May 6, 2026 16:18
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: 0xisk <0xisk@proton.me>
Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
)

Signed-off-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: 0xisk <0xisk@proton.me>
Signed-off-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: 0xisk <0xisk@proton.me>
Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: oz-release-app-midnight[bot] <263459143+oz-release-app-midnight[bot]@users.noreply.github.com>
0xisk and others added 8 commits June 8, 2026 15:38
…#576)

Signed-off-by: Andrew Fleming <fleming.andrew@protonmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: 0xisk <0xisk@proton.me>
Co-authored-by: oz-release-app-midnight[bot] <263459143+oz-release-app-midnight[bot]@users.noreply.github.com>
Sync `post-release` with the current `main` so the multisig suite can be
migrated cleanly. `main` has advanced since `post-release` branched
(0.1.0 / 0.2.0 releases, per-module `Initializable` split #562, pk->sk
refactor, witness relocation #528), leaving `post-release -> main`
conflicting in shared infra files only.

The multisig modules do not conflict: they import only other multisig
modules plus the standard library. Conflicts were limited to and
resolved in favour of main's conventions while preserving the multisig
additions:

* .gitignore, CHANGELOG.md: keep both sides' entries.
* contracts/package.json: keep main's hierarchical build, SKIP_ZK test
  scripts, and modern dep versions; re-add fast-check.
* contracts/vitest.config.ts: keep main's per-`.ts` 95% coverage gate.
* contracts/src/utils/test/utils.test.ts: keep all describe blocks.
* yarn.lock: regenerated via yarn install.

After this lands, `post-release -> main` (#594) is conflict-free. The
multisig modules and utils additions still compile cleanly.
@0xisk
0xisk requested review from a team as code owners June 15, 2026 10:36
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5df6a3cd-07ac-47a8-8eb6-70c853965afc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sync-main-into-post-release

Comment @coderabbitai help to get the list of available commands and usage tips.

The merge committed main's lockfile while package.json adds
fast-check; CI's `yarn install --immutable` rejected the drift.
Regenerate so fast-check@4.8.0 and pure-rand are recorded.
@0xisk
0xisk enabled auto-merge (squash) June 15, 2026 11:29
main renamed the simulator package from
`@openzeppelin-compact/contracts-simulator` to
`@openzeppelin/compact-simulator` (#523). The multisig simulators
still used the old name, so all 11 multisig suites failed to load
(ERR_MODULE_NOT_FOUND) after merging main. The API (createSimulator,
BaseSimulatorOptions) is unchanged.
@0xisk
0xisk merged commit 79fffec into post-release Jun 15, 2026
9 checks passed
@0xisk
0xisk deleted the chore/sync-main-into-post-release branch June 15, 2026 11:54
0xisk added a commit that referenced this pull request Jun 15, 2026
PR #595 was squash-merged, so post-release carried main's file content
but not its commit ancestry. Git therefore re-derived conflicts for
#594 (post-release -> main) from the stale 2024-era merge base.

This real merge links main's history into post-release. All six
conflicts (.gitignore, CHANGELOG.md, contracts/package.json, turbo.json,
contracts/src/utils/test/utils.test.ts, yarn.lock) resolve to the
multisig-inclusive content; main's forward changes auto-merged. Net file
change is zero, so the value is purely the ancestry link that makes #594
cleanly mergeable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants