chore: merge main into post-release - #595
Merged
Merged
Conversation
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andrew Fleming <fleming.andrew@protonmail.com> Co-authored-by: 0xisk <0xisk@proton.me> Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Signed-off-by: Andrew Fleming <fleming.andrew@protonmail.com> Co-authored-by: 0xisk <0xisk@proton.me> Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Co-authored-by: 0xisk <iskander.andrews@openzeppelin.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: oz-release-app-midnight[bot] <263459143+oz-release-app-midnight[bot]@users.noreply.github.com>
…#576) Signed-off-by: Andrew Fleming <fleming.andrew@protonmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: 0xisk <0xisk@proton.me>
Co-authored-by: oz-release-app-midnight[bot] <263459143+oz-release-app-midnight[bot]@users.noreply.github.com>
Sync `post-release` with the current `main` so the multisig suite can be migrated cleanly. `main` has advanced since `post-release` branched (0.1.0 / 0.2.0 releases, per-module `Initializable` split #562, pk->sk refactor, witness relocation #528), leaving `post-release -> main` conflicting in shared infra files only. The multisig modules do not conflict: they import only other multisig modules plus the standard library. Conflicts were limited to and resolved in favour of main's conventions while preserving the multisig additions: * .gitignore, CHANGELOG.md: keep both sides' entries. * contracts/package.json: keep main's hierarchical build, SKIP_ZK test scripts, and modern dep versions; re-add fast-check. * contracts/vitest.config.ts: keep main's per-`.ts` 95% coverage gate. * contracts/src/utils/test/utils.test.ts: keep all describe blocks. * yarn.lock: regenerated via yarn install. After this lands, `post-release -> main` (#594) is conflict-free. The multisig modules and utils additions still compile cleanly.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The merge committed main's lockfile while package.json adds fast-check; CI's `yarn install --immutable` rejected the drift. Regenerate so fast-check@4.8.0 and pure-rand are recorded.
0xisk
enabled auto-merge (squash)
June 15, 2026 11:29
main renamed the simulator package from `@openzeppelin-compact/contracts-simulator` to `@openzeppelin/compact-simulator` (#523). The multisig simulators still used the old name, so all 11 multisig suites failed to load (ERR_MODULE_NOT_FOUND) after merging main. The API (createSimulator, BaseSimulatorOptions) is unchanged.
pepebndc
approved these changes
Jun 15, 2026
0xisk
added a commit
that referenced
this pull request
Jun 15, 2026
PR #595 was squash-merged, so post-release carried main's file content but not its commit ancestry. Git therefore re-derived conflicts for #594 (post-release -> main) from the stale 2024-era merge base. This real merge links main's history into post-release. All six conflicts (.gitignore, CHANGELOG.md, contracts/package.json, turbo.json, contracts/src/utils/test/utils.test.ts, yarn.lock) resolve to the multisig-inclusive content; main's forward changes auto-merged. Net file change is zero, so the value is purely the ancestry link that makes #594 cleanly mergeable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Merges the current
mainintopost-releaseso the multisig suite can be migrated cleanly. After this lands, thepost-release → mainPR (#594) becomes conflict-free and mergeable while keeping Andrew's original commit history.Why
mainhas advanced sincepost-releasebranched (0.1.0 / 0.2.0 releases, per-moduleInitializablesplit #562,pk→skrefactor, witness relocation #528). A directpost-release → mainmerge therefore conflicts in shared infra files. This PR resolves those conflicts on thepost-releaseside.Conflicts resolved
The multisig modules do not conflict — they import only other multisig modules plus the Compact standard library. Resolution kept
main's conventions and preserved the multisig additions:.gitignore,CHANGELOG.md: keep both sides' entries.contracts/package.json: keepmain's hierarchical build +SKIP_ZKtest scripts and modern dependency versions; re-addfast-check.contracts/vitest.config.ts: keepmain's per-.ts95% coverage gate.contracts/src/utils/test/utils.test.ts: keep alldescribeblocks.yarn.lock: regenerated viayarn install.All 21 multisig
.compactmodules and theutilsadditions compile cleanly on the merged tree.Unblocks #594.
PR Checklist
Further comments
No source behaviour changes — this is purely a merge/conflict resolution to prepare
post-releasefor migration. Tests and docs come with the already-reviewed feature commits.