Skip to content

ci(test): fix test-suite timeout cancellations - #555

Merged
0xisk merged 2 commits into
post-releasefrom
ci/test-suite-timeout-post-release
Jun 9, 2026
Merged

ci(test): fix test-suite timeout cancellations#555
0xisk merged 2 commits into
post-releasefrom
ci/test-suite-timeout-post-release

Conversation

@0xisk

@0xisk 0xisk commented Jun 8, 2026

Copy link
Copy Markdown
Member

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Fixes #???

Port of #554 onto post-release.

The Run Test Suite job is cancelled with "The job has exceeded the maximum execution time of 15m0s" → "The operation was canceled." This reads like a failure but is a timeout. The turbo compact step now consumes ~14 of the 15-minute budget compiling ZK circuits (the multisig/ group alone is ~8 minutes), so the test step never meaningfully runs before the limit hits.

This PR, against post-release:

  • Raises timeout-minutes from 15 to 30 in test.yml.
  • Pins actions/cache from v4.3.0 (Node 20, deprecated on runners from 2026-06-16) to v5.0.5 (Node 24).

PR Checklist

Further comments

CI-only change targeting post-release. Same two commits as #554 (already merged to main).

0xisk added 2 commits June 8, 2026 16:07
The `turbo compact` step now spends ~14 of the 15-minute budget
compiling ZK circuits (the multisig group alone takes ~8 minutes),
leaving no room for the test step. GitHub cancels the job at the
limit, surfacing as "The operation was canceled" rather than a real
failure.

Bump the budget to 30 minutes so the full compile + type-check +
test pipeline can finish.
v4.3.0 runs on Node.js 20, which GitHub deprecates on the runners
from 2026-06-16. v5.0.5 runs on Node.js 24 and clears the
deprecation warning.
@0xisk
0xisk requested review from a team as code owners June 8, 2026 14:07
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1e86cd9e-c892-48ca-b353-845132190406

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/test-suite-timeout-post-release

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xisk
0xisk enabled auto-merge (squash) June 8, 2026 14:17
@0xisk
0xisk disabled auto-merge June 8, 2026 14:22
@0xisk
0xisk enabled auto-merge (squash) June 8, 2026 14:22
@tirumerla
tirumerla disabled auto-merge June 9, 2026 13:48
@tirumerla
tirumerla enabled auto-merge (squash) June 9, 2026 13:49
@0xisk
0xisk disabled auto-merge June 9, 2026 13:52
@0xisk
0xisk merged commit 640e469 into post-release Jun 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants