ci(test): fix test-suite timeout cancellations - #555
Merged
Conversation
The `turbo compact` step now spends ~14 of the 15-minute budget compiling ZK circuits (the multisig group alone takes ~8 minutes), leaving no room for the test step. GitHub cancels the job at the limit, surfacing as "The operation was canceled" rather than a real failure. Bump the budget to 30 minutes so the full compile + type-check + test pipeline can finish.
v4.3.0 runs on Node.js 20, which GitHub deprecates on the runners from 2026-06-16. v5.0.5 runs on Node.js 24 and clears the deprecation warning.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
pepebndc
approved these changes
Jun 8, 2026
0xisk
enabled auto-merge (squash)
June 8, 2026 14:17
0xisk
disabled auto-merge
June 8, 2026 14:22
0xisk
enabled auto-merge (squash)
June 8, 2026 14:22
tirumerla
approved these changes
Jun 9, 2026
tirumerla
disabled auto-merge
June 9, 2026 13:48
tirumerla
enabled auto-merge (squash)
June 9, 2026 13:49
0xisk
disabled auto-merge
June 9, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an
xin the boxes that applyFixes #???
Port of #554 onto
post-release.The
Run Test Suitejob is cancelled with "The job has exceeded the maximum execution time of 15m0s" → "The operation was canceled." This reads like a failure but is a timeout. Theturbo compactstep now consumes ~14 of the 15-minute budget compiling ZK circuits (themultisig/group alone is ~8 minutes), so the test step never meaningfully runs before the limit hits.This PR, against
post-release:timeout-minutesfrom 15 to 30 intest.yml.actions/cachefrom v4.3.0 (Node 20, deprecated on runners from 2026-06-16) to v5.0.5 (Node 24).PR Checklist
Further comments
CI-only change targeting
post-release. Same two commits as #554 (already merged tomain).