Update filebucket content acceptance tests for literal checksum semantics - #602
Open
silug wants to merge 1 commit into
Open
Update filebucket content acceptance tests for literal checksum semantics#602silug wants to merge 1 commit into
silug wants to merge 1 commit into
Conversation
…tics openvox#170 removed the implicit filebucket retrieval for file content values that look like checksums; such content is now always managed literally. Two acceptance tests still exercised the removed behavior and fail on all platforms (acceptance run 31157133263, openvox suite shard:group3; also present but masked behind the lookup failures in run 31098859281): - ticket_6541_invalid_filebucket_files.rb asserted that checksum-like content never overwrites the target and that a well-formed checksum retrieves bucket content. Rewritten as a regression test for the new semantics: checksum-like content -- malformed or well-formed -- is written literally, which is exactly the capability whose absence motivated the removal. - resource/file/content_attribute.rb ended with a checksum-from-filebucket scenario; that block is removed with a comment pointing at the rewritten test. The raw-content, checksum-type, and illegal-timestamp coverage is unchanged. Verified on a local beaker rig against openvox-agent 9.0.0~beta2: both tests reproduce the pipeline failures unmodified and pass with this change. Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
#170 removed the implicit filebucket retrieval for file content values that look like checksums; such content is now always managed literally. Two acceptance tests still exercised the removed behavior and fail on all platforms (acceptance run 31157133263, openvox suite
shard:group3; also present but masked behind the lookup failures in run 31098859281):ticket_6541_invalid_filebucket_files.rbasserted that checksum-like content never overwrites the target and that a well-formed checksum retrieves bucket content. Rewritten as a regression test for the new semantics: checksum-like content -- malformed or well-formed -- is written literally, which is exactly the capability whose absence motivated the removal.resource/file/content_attribute.rbended with a checksum-from-filebucket scenario; that block is removed with a comment pointing at the rewritten test. The raw-content, checksum-type, and illegal-timestamp coverage is unchanged.Verified on a local beaker rig against openvox-agent
9.0.0~beta2: both tests reproduce the pipeline failures unmodified and pass with this change.Generated by Claude Code
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent