Skip to content

Request report storage explicitly in cached-catalog drift test - #598

Open
silug wants to merge 1 commit into
OpenVoxProject:mainfrom
silug:drift-test-reports-store
Open

Request report storage explicitly in cached-catalog drift test#598
silug wants to merge 1 commit into
OpenVoxProject:mainfrom
silug:drift-test-reports-store

Conversation

@silug

@silug silug commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Short description

#583 changed the default of the reports setting from store to none, so the server now accepts report submissions and hands them to no processors. cached_catalog_remediate_local_drift.rb asserted that a submitted report appears under the server reportdir while relying on the old default, and began failing on all platforms in acceptance run 31098859281 (openvox suite, shard:group4). Diagnosis on a local rig confirmed the agent PUT succeeds (200 in the server access log) while nothing is stored.

Set reports = store and a test-owned reportdir in master_opts, matching the pattern the other report-checking acceptance tests (reports/submission.rb, reports/cached_catalog_status_in_report.rb, direct_puppet/catalog_uuid_correlates_catalogs_with_reports.rb) already use -- this test was the only one relying on the default. Also fix the reversed assert_equal argument order in the two report-count assertions so failure messages report expected and actual correctly, and clean up the reportdir in teardown.

Verified on a local beaker rig against openvox-agent 9.0.0~beta2 and openvox-server 9.0.0~beta4: the unmodified test reproduces the pipeline failure; with this change it passes.

Note for release notes: the reports=none default change itself is user-visible (report YAML consumers must now set reports=store) and should be called out in the 9.0 release notes.

Generated by Claude Code

Checklist

I have:

openvox#583 changed the default of the reports setting from store to none, so the server now accepts report submissions and hands them to no processors. cached_catalog_remediate_local_drift.rb asserted that a submitted report appears under the server reportdir while relying on the old default, and began failing on all platforms in acceptance run 31098859281 (openvox suite, shard:group4). Diagnosis on a local rig confirmed the agent PUT succeeds (200 in the server access log) while nothing is stored.

Set reports = store and a test-owned reportdir in master_opts, matching the pattern the other report-checking acceptance tests (reports/submission.rb, reports/cached_catalog_status_in_report.rb, direct_puppet/catalog_uuid_correlates_catalogs_with_reports.rb) already use -- this test was the only one relying on the default. Also fix the reversed assert_equal argument order in the two report-count assertions so failure messages report expected and actual correctly, and clean up the reportdir in teardown.

Verified on a local beaker rig against openvox-agent 9.0.0~beta2 and openvox-server 9.0.0~beta4: the unmodified test reproduces the pipeline failure; with this change it passes.

Note for release notes: the reports=none default change itself is user-visible (report YAML consumers must now set reports=store) and should be called out in the 9.0 release notes.

Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@bastelfreak bastelfreak closed this Aug 7, 2026
@bastelfreak bastelfreak reopened this Aug 7, 2026
@bastelfreak bastelfreak mentioned this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants