Request report storage explicitly in cached-catalog drift test - #598
Open
silug wants to merge 1 commit into
Open
Request report storage explicitly in cached-catalog drift test#598silug wants to merge 1 commit into
silug wants to merge 1 commit into
Conversation
openvox#583 changed the default of the reports setting from store to none, so the server now accepts report submissions and hands them to no processors. cached_catalog_remediate_local_drift.rb asserted that a submitted report appears under the server reportdir while relying on the old default, and began failing on all platforms in acceptance run 31098859281 (openvox suite, shard:group4). Diagnosis on a local rig confirmed the agent PUT succeeds (200 in the server access log) while nothing is stored. Set reports = store and a test-owned reportdir in master_opts, matching the pattern the other report-checking acceptance tests (reports/submission.rb, reports/cached_catalog_status_in_report.rb, direct_puppet/catalog_uuid_correlates_catalogs_with_reports.rb) already use -- this test was the only one relying on the default. Also fix the reversed assert_equal argument order in the two report-count assertions so failure messages report expected and actual correctly, and clean up the reportdir in teardown. Verified on a local beaker rig against openvox-agent 9.0.0~beta2 and openvox-server 9.0.0~beta4: the unmodified test reproduces the pipeline failure; with this change it passes. Note for release notes: the reports=none default change itself is user-visible (report YAML consumers must now set reports=store) and should be called out in the 9.0 release notes. Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
#583 changed the default of the reports setting from
storetonone, so the server now accepts report submissions and hands them to no processors.cached_catalog_remediate_local_drift.rbasserted that a submitted report appears under the serverreportdirwhile relying on the old default, and began failing on all platforms in acceptance run 31098859281 (openvoxsuite,shard:group4). Diagnosis on a local rig confirmed the agent PUT succeeds (200 in the server access log) while nothing is stored.Set
reports = storeand a test-ownedreportdirinmaster_opts, matching the pattern the other report-checking acceptance tests (reports/submission.rb,reports/cached_catalog_status_in_report.rb,direct_puppet/catalog_uuid_correlates_catalogs_with_reports.rb) already use -- this test was the only one relying on the default. Also fix the reversedassert_equal argumentorder in the two report-count assertions so failure messages report expected and actual correctly, and clean up thereportdirin teardown.Verified on a local beaker rig against openvox-agent
9.0.0~beta2and openvox-server9.0.0~beta4: the unmodified test reproduces the pipeline failure; with this change it passes.Note for release notes: the
reports=nonedefault change itself is user-visible (report YAML consumers must now setreports=store) and should be called out in the 9.0 release notes.Generated by Claude Code
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent