Skip to content

Compare facterversion against installed facter in acceptance test - #597

Open
silug wants to merge 1 commit into
OpenVoxProject:mainfrom
silug:facter-version-acceptance
Open

Compare facterversion against installed facter in acceptance test#597
silug wants to merge 1 commit into
OpenVoxProject:mainfrom
silug:facter-version-acceptance

Conversation

@silug

@silug silug commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Short description

ensure_puppet_facts_can_use_facter.rb asserted that the facterversion fact reported a major version of at most 5. Hardcoding the major version breaks on every openfact major bump -- openfact 6.0.0 shipped in openvox-agent 9.0.0~beta2 made the test fail on all 11 platforms in acceptance run 31098859281 (openvox-agent suite).

Compare the fact against the output of facter --version on the agent instead, which expresses what the test actually cares about (puppet facts uses the bundled facter) and survives future major bumps.

Verified on a local beaker rig against openvox-agent 9.0.0~beta2 (openfact 6.0.0): the unmodified test fails with the same Minitest assertion as the pipeline; with this change it passes.

Generated by Claude Code

Checklist

I have:

ensure_puppet_facts_can_use_facter.rb asserted that the facterversion fact reported a major version of at most 5. Hardcoding the major version breaks on every openfact major bump -- openfact 6.0.0 shipped in openvox-agent 9.0.0~beta2 made the test fail on all 11 platforms in acceptance run 31098859281 (openvox-agent suite).

Compare the fact against the output of facter --version on the agent instead, which expresses what the test actually cares about (puppet facts uses the bundled facter) and survives future major bumps.

Verified on a local beaker rig against openvox-agent 9.0.0~beta2 (openfact 6.0.0): the unmodified test fails with the same Minitest assertion as the pipeline; with this change it passes.

Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@bastelfreak bastelfreak closed this Aug 7, 2026
@bastelfreak bastelfreak reopened this Aug 7, 2026
@bastelfreak bastelfreak mentioned this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants