Compare facterversion against installed facter in acceptance test - #597
Open
silug wants to merge 1 commit into
Open
Compare facterversion against installed facter in acceptance test#597silug wants to merge 1 commit into
silug wants to merge 1 commit into
Conversation
ensure_puppet_facts_can_use_facter.rb asserted that the facterversion fact reported a major version of at most 5. Hardcoding the major version breaks on every openfact major bump -- openfact 6.0.0 shipped in openvox-agent 9.0.0~beta2 made the test fail on all 11 platforms in acceptance run 31098859281 (openvox-agent suite). Compare the fact against the output of facter --version on the agent instead, which expresses what the test actually cares about (puppet facts uses the bundled facter) and survives future major bumps. Verified on a local beaker rig against openvox-agent 9.0.0~beta2 (openfact 6.0.0): the unmodified test fails with the same Minitest assertion as the pipeline; with this change it passes. Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
ensure_puppet_facts_can_use_facter.rb asserted that the facterversion fact reported a major version of at most 5. Hardcoding the major version breaks on every openfact major bump -- openfact 6.0.0 shipped in openvox-agent 9.0.0~beta2 made the test fail on all 11 platforms in acceptance run 31098859281 (openvox-agent suite).
Compare the fact against the output of facter --version on the agent instead, which expresses what the test actually cares about (puppet facts uses the bundled facter) and survives future major bumps.
Verified on a local beaker rig against openvox-agent 9.0.0~beta2 (openfact 6.0.0): the unmodified test fails with the same Minitest assertion as the pipeline; with this change it passes.
Generated by Claude Code
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent