fix: connect SessionManager to the bus in the skills process regardless of intent-service by JarbasAl · Pull Request #855 · OpenVoiceOS/ovos-core

JarbasAl · 2026-08-13T01:07:01Z

🤖 Auto-generated by Claude Fable 5 (claude-fable-5) via Claude Code — NOT human-reviewed. Verify before acting.

The skills process only connected SessionManager to the bus when the intent service happened to live in the same process. In a distributed setup (skills in their own container) sessions never synced, so anything session-based quietly fell back to defaults.

This connects SessionManager to the bus unconditionally when the skills process starts. One-line change plus tests that run the skills process standalone and check the session actually tracks the bus.

Full unit suite green; also exercised in the mixed-version harness where the standalone-skills cell caught the original bug.

coderabbitai · 2026-08-13T01:07:11Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 68c243e2-9004-4b26-9627-fc35294b0a69

📥 Commits

Reviewing files that changed from the base of the PR and between cb479ae and c1d5a71.

📒 Files selected for processing (4)

ovos_core/intent_services/service.py
ovos_core/skill_manager.py
test/unittests/test_manager.py
test/unittests/test_skill_manager.py

📝 Walkthrough

Walkthrough

IntentService and SkillManager now connect SessionManager to the message bus only when required. Tests reset shared bus state, update handler expectations, and verify wiring with intent service enabled or disabled.

Changes

SessionManager bus wiring

Layer / File(s)	Summary
Guard IntentService bus connection `ovos_core/intent_services/service.py`	`IntentService` connects `SessionManager` only when the existing bus differs from its bus.
Connect SessionManager from SkillManager `ovos_core/skill_manager.py`	`SkillManager` imports `SessionManager` and connects it during initialization when required.
Validate shared bus state and handler registration `test/unittests/test_manager.py`, `test/unittests/test_skill_manager.py`	Tests reset shared bus state, include SessionManager handlers in expectations, and verify connection behavior and single registration.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SkillManager
  participant IntentService
  participant SessionManager
  participant MessageBus
  SkillManager->>SessionManager: connect when the manager bus differs
  IntentService->>SessionManager: connect when the service bus differs
  SessionManager->>MessageBus: register session handlers
  MessageBus-->>SessionManager: retain one handler set per connected bus

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/skillmanager-sessionmanager-bus

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-13T01:07:42Z

Another day, another set of automated checks. Let's see! 🌅

I've aggregated the results of the automated checks for this PR below.

🏷️ Release Preview

Coming soon to a stable branch near you! 📽️

Current: 2.6.3a1 → Next: 2.6.4a1

Signal	Value
Label	`fix`
PR title	`fix: connect SessionManager to the bus in the skills process regardless of intent-service`
Bump	build

✅ PR title follows conventional commit format.

🚀 Release Channel Compatibility

Predicted next version: 2.6.4a1

Channel	Status	Note	Current Constraint
Stable	❌	Too new (must be <1.4.0)	`ovos-core>=1.3.1,<1.4.0`
Testing	✅	Compatible	`ovos-core>=2.1.1,<3.0.0`
Alpha	✅	Compatible	`ovos-core>=2.2.4a1`

🔒 Security (pip-audit)

Scanning for any potential buffer overflows. 🌊

✅ No known vulnerabilities found (113 packages scanned).

🌍 Locale Build

The data is in, and it's looking interesting! 🧐

✅ Locale properly configured (64 files, 17 languages)

Locale directories found:

ovos_core/intent_services/locale

Localization coverage:

ovos_core/intent_services/locale: 64 files in 17 languages (en-us, ca-es, fa-ir, de-de, gl-es...)

pyproject.toml: ✅ [tool.setuptools.package-data.ovos_core] includes locale

intent_services/locale/*/*.voc

Build manifest: ✅ 31 locale files included in package

📚 Docs

Ensuring the codebase remains stable and healthy. 🛡️

✅ All required documentation files present.

✅ README.md

📋 Repo Health

Scanning for any signs of 'comment' bad breath. 🌬️

✅ All required files present.

Latest Version: 2.6.3a1

✅ ovos_core/version.py — Version file
✅ README.md — README
✅ LICENSE — License file
✅ pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
✅ CHANGELOG.md — Changelog
✅ ovos_core/version.py has valid version block markers

🔌 Plugin Detection

Let's see if this plugin can be found by the plugin manager! 🔌

❌ Plugin Status: ERRORS (1)

Plugin Info:

Name: ovos-core
Description: The spiritual successor to Mycroft AI, OVOS is flexible voice assistant software that can be run almost anywhere!

OPM Detection:

Plugin Type	Wheel	Editable
pipeline	✅	✅

Entry Point Validation:

Entry Point	Type	Import	Interface
`ovos-converse-pipeline-plugin`	pipeline	✅ 1673ms	⊘
`ovos-fallback-pipeline-plugin`	pipeline	✅ 2ms	⊘
`ovos-stop-pipeline-plugin`	pipeline	✅ 55ms	⊘

⊘ No settingsmeta.json
✅ requires-python >=3.10 — running Python 3.11

Issues:

❌ Import time for ovos-converse-pipeline-plugin exceeds 500ms (1673ms)
⚠️ No settingsmeta.json found
⚠️ No settingsmeta.json found

📊 Coverage

Scanning for any 'untested' alerts! 🚨

⚠️ 66.4% total coverage

Files below 80% coverage (9 files)

File	Coverage	Missing lines
`ovos_core/__init__.py`	0.0%	7
`ovos_core/__main__.py`	0.0%	26
`ovos_core/intent_services/__init__.py`	0.0%	1
`ovos_core/version.py`	0.0%	18
`ovos_core/transformers.py`	33.3%	18
`ovos_core/skill_installer.py`	45.3%	134
`ovos_core/intent_services/service.py`	61.5%	154
`ovos_core/skill_manager.py`	62.0%	157
`ovos_core/intent_services/dispatcher.py`	73.4%	29

Full report: download the coverage-report artifact.

🔨 Build Tests

Verifying that everything is in its right place. 🧘

✅ All versions pass

Python	Build	Install	Tests
3.10	✅	✅	✅
3.11	✅	✅	✅
3.12	✅	✅	✅
3.13	✅	✅	✅
3.14	✅	✅	✅

🔌 Skill Tests (ovoscope)

Checking for any potential conversational dead ends. 🚧

✅ 4/40 passed

❌ **TestAdaptIntent** — 0/4

Test	Result
`test_intent_blacklist`	❌ subtests passed
`test_skill_blacklist`	❌ subtests passed
`test_adapt_match`	❌ subtests passed
`test_padatious_no_match`	❌ subtests passed

test_intent_blacklist failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_skill_blacklist failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_adapt_match failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestCancelIntentMidSentence** — 0/1

Test	Result
`test_cancel_match`	❌ subtests passed

test_cancel_match failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestConverse** — 0/1

Test	Result
`test_parrot_mode`	❌ subtests passed

test_parrot_mode failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestCountSkills** — 0/4

Test	Result
`test_count_infinity_global`	❌ subtests passed
`test_count_infinity_stop_low`	❌ subtests passed
`test_count`	❌ subtests passed
`test_count_infinity_active`	❌ subtests passed

test_count_infinity_global failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_count_infinity_stop_low failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_count failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestDeactivate** — 2/3

Test	Result
`test_activate`	✅ passed
`test_deactivate_inside_converse`	❌ subtests passed
`test_deactivate`	✅ passed

test_deactivate_inside_converse failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestFallback** — 0/1

Test	Result
`test_fallback_match`	❌ subtests passed

test_fallback_match failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

✅ **TestGGWaveSkillInstall** — 2/2

❌ **TestGlobalStopVocWithActiveSkill** — 0/1

Test	Result
`test_global_stop_voc_with_active_skill`	❌ subtests passed

test_global_stop_voc_with_active_skill failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestGlobalStopVocabulary** — 0/2

Test	Result
`test_stop_voc_exact_still_works`	❌ subtests passed
`test_global_stop_voc_no_active_skills`	❌ subtests passed

test_stop_voc_exact_still_works failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_global_stop_voc_no_active_skills failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestIntentPipelineRouting** — 0/4

Test	Result
`test_padatious_intent_matched`	❌ subtests passed
`test_high_priority_stage_handles_before_low`	❌ subtests passed
`test_no_match_produces_intent_failure`	❌ subtests passed
`test_blacklisted_skill_falls_through_to_failure`	❌ subtests passed

test_padatious_intent_matched failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_high_priority_stage_handles_before_low failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_no_match_produces_intent_failure failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestLangDisambiguation** — 0/4

Test	Result
`test_metadata_preferred_over_text_detection`	❌ subtests passed
`test_invalid_lang_detection`	❌ subtests passed
`test_stt_lang`	❌ subtests passed
`test_lang_text_detection`	❌ subtests passed

test_metadata_preferred_over_text_detection failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_invalid_lang_detection failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_stt_lang failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestLegacyIntentIdBackCompat** — 0/2

Test	Result
`test_legacy_blacklist_id_suppresses`	❌ subtests passed
`test_legacy_dispatch_topic_fires_handler`	❌ subtests passed

test_legacy_blacklist_id_suppresses failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_legacy_dispatch_topic_fires_handler failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestNoSkills** — 0/2

Test	Result
`test_routing`	❌ subtests passed
`test_complete_failure`	❌ subtests passed

test_routing failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_complete_failure failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestPadatiousIntent** — 0/4

Test	Result
`test_intent_blacklist`	❌ subtests passed
`test_padatious_match`	❌ subtests passed
`test_adapt_no_match`	❌ subtests passed
`test_skill_blacklist`	❌ subtests passed

test_intent_blacklist failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_padatious_match failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_adapt_no_match failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestStopNoSkills** — 0/3

Test	Result
`test_exact`	❌ subtests passed
`test_not_exact_high`	❌ subtests passed
`test_not_exact_med`	❌ subtests passed

test_exact failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_not_exact_high failure:

[gw0] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

test_not_exact_med failure:

[gw2] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestStopServiceNotASkill** — 0/1

Test	Result
`test_stop_service_is_not_a_skill`	❌ subtests passed

test_stop_service_is_not_a_skill failure:

[gw1] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

❌ **TestStopSkillCanHandleFalse** — 0/1

Test	Result
`test_stop_with_active_skill_ping_pong`	❌ subtests passed

test_stop_with_active_skill_ping_pong failure:

[gw3] linux -- Python 3.11.15 /opt/hostedtoolcache/Python/3.11.15/x64/bin/python

🚌 Bus Coverage

Quantifying the thoroughness of our end-to-end signal tracking. 🧮

🔴 Coverage Summary

Metric	Status	Coverage
Listeners	`█░░░░░░░░░` 10.5%	24/229 handlers
Emitters	`██████████` 100%	34/34 observed
Assertions	`██████████` 100%	34/34 asserted

📊 Per-Skill Breakdown

Skill	Listeners	Observed	Asserted
`AdaptPipeline`	0/14 (0.0%)	0/0	0/0
`ConverseService`	1/4 (25.0%)	0/0	0/0
`DomainAdaptPipeline`	0/14 (0.0%)	0/0	0/0
`FallbackService`	0/2 (0.0%)	0/0	0/0
`HierarchicalAdaptPipeline`	0/14 (0.0%)	0/0	0/0
`IntentDispatcher`	1/2 (50.0%)	0/0	0/0
`IntentManifest`	0/8 (0.0%)	0/0	0/0
`IntentService`	1/4 (25.0%)	0/0	0/0
`Model2VecPrototypePipeline`	0/12 (0.0%)	0/0	0/0
`PadaciosoPipeline`	0/11 (0.0%)	0/0	0/0
`PadatiousPipeline`	0/15 (0.0%)	0/0	0/0
`SkillManager`	0/5 (0.0%)	0/0	0/0
`StopService`	2/2 (100.0%)	0/0	0/0
`__core__`	7/32 (21.9%)	7/7	7/7
`ovos-skill-count.openvoiceos`	4/21 (19.0%)	8/8	8/8
`ovos-skill-hello-world.openvoiceos`	0/26 (0.0%)	0/0	0/0
`ovos-skill-parrot.openvoiceos`	6/39 (15.4%)	11/11	11/11
`stop.openvoiceos`	0/0 (0.0%)	8/8	8/8
`type`	2/4 (50.0%)	0/0	0/0

🔍 Detailed Message Type Breakdown

`AdaptPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.keyword (Intent)
❌ detach_intent
❌ detach_skill
❌ intent.service.adapt.get
❌ intent.service.adapt.manifest.get
❌ intent.service.adapt.vocab.manifest.get
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
❌ register_intent
❌ register_vocab

`ConverseService`

⚠️ Uncovered Listeners:

❌ intent.service.active_skills.get
❌ intent.service.skills.activate
❌ intent.service.skills.deactivate
✅ Covered Listeners:
✅ converse:skill (4x)

`DomainAdaptPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.keyword (Intent)
❌ detach_intent
❌ detach_skill
❌ intent.service.adapt.get
❌ intent.service.adapt.manifest.get
❌ intent.service.adapt.vocab.manifest.get
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
❌ register_intent
❌ register_vocab

`FallbackService`

⚠️ Uncovered Listeners:

❌ ovos.skills.fallback.deregister
❌ ovos.skills.fallback.register

`HierarchicalAdaptPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.keyword (Intent)
❌ detach_intent
❌ detach_skill
❌ intent.service.adapt.get
❌ intent.service.adapt.manifest.get
❌ intent.service.adapt.vocab.manifest.get
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
❌ register_intent
❌ register_vocab

`IntentDispatcher`

⚠️ Uncovered Listeners:

❌ mycroft.skill.handler.error
✅ Covered Listeners:
✅ mycroft.skill.handler.complete (14x)

`IntentManifest`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.describe (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.list (Intent)
❌ ovos.intent.register.keyword (Intent)
❌ ovos.intent.register.template (Intent)
❌ ovos.skill.deregister

`IntentService`

⚠️ Uncovered Listeners:

❌ intent.service.intent.get (Intent)
❌ intent.service.pipelines.reload
❌ intent.service.skills.deactivate
✅ Covered Listeners:
✅ ovos.utterance.handle (14x)

`Model2VecPrototypePipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.template (Intent)
❌ padatious:register_intent (Intent)
❌ detach_intent
❌ detach_skill
❌ mycroft.ready
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister
❌ register_intent

`PadaciosoPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.template (Intent)
❌ padatious:register_entity (Intent)
❌ padatious:register_intent (Intent)
❌ detach_intent
❌ detach_skill
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister

`PadatiousPipeline`

⚠️ Uncovered Listeners:

❌ ovos.intent.deregister (Intent)
❌ ovos.intent.disable (Intent)
❌ ovos.intent.enable (Intent)
❌ ovos.intent.register.template (Intent)
❌ padatious:register_entity (Intent)
❌ padatious:register_intent (Intent)
❌ detach_intent
❌ detach_skill
❌ intent.service.padatious.entities.manifest.get
❌ intent.service.padatious.get
❌ intent.service.padatious.manifest.get
❌ mycroft.skills.train
❌ ovos.entity.deregister
❌ ovos.entity.register
❌ ovos.skill.deregister

`SkillManager`

⚠️ Uncovered Listeners:

❌ skill.converse.get_response.disable
❌ skillmanager.activate
❌ skillmanager.deactivate
❌ skillmanager.keep
❌ skillmanager.list

`StopService`

✅ Covered Listeners:

✅ stop:global (2x)
✅ stop:skill (2x)

`core`

⚠️ Uncovered Listeners:

❌ add_context
❌ clear_context
❌ message
❌ mycroft.ovos-skill-count.openvoiceos.all_loaded
❌ mycroft.ovos-skill-count.openvoiceos.is_alive
❌ mycroft.ovos-skill-count.openvoiceos.is_ready
❌ mycroft.ovos-skill-hello-world.openvoiceos.all_loaded
❌ mycroft.ovos-skill-hello-world.openvoiceos.is_alive
❌ mycroft.ovos-skill-hello-world.openvoiceos.is_ready
❌ mycroft.ovos-skill-parrot.openvoiceos.all_loaded
❌ mycroft.ovos-skill-parrot.openvoiceos.is_alive
❌ mycroft.ovos-skill-parrot.openvoiceos.is_ready
❌ ovos-skill-count.openvoiceos.set
❌ ovos-skill-hello-world.openvoiceos.set
❌ ovos-skill-parrot.openvoiceos.set
❌ ovos.ggwave.disable
❌ ovos.ggwave.enable
❌ ovos.pip.install
❌ ovos.pip.uninstall
❌ ovos.session.sync
❌ ovos.session.update_default
❌ ovos.skills.install
❌ ovos.skills.uninstall
❌ remove_context
❌ skill.converse.get_response.enable
✅ Covered Listeners:
✅ ovos-skill-count.openvoiceos.stop.response (1x)
✅ ovos.skills.converse.force_timeout (2x)
✅ ovos.utterance.handled (29x)
✅ ovos.utterance.speak (14x)
✅ skill.converse.pong (3x)
✅ skill.converse.response (2x)
✅ skill.stop.pong (1x)

📤 Emitters:

✅ mycroft.audio.play_sound (Asserted ✅)
✅ ovos-skill-parrot.openvoiceos.converse.ping (Asserted ✅)
✅ ovos.intent.unmatched (Asserted ✅)
✅ ovos.utterance.cancelled (Asserted ✅)
✅ ovos.utterance.handle (Asserted ✅)
✅ ovos.utterance.handled (Asserted ✅)
✅ recognizer_loop:utterance (Asserted ✅)

`ovos-skill-count.openvoiceos`

⚠️ Uncovered Listeners:

❌ ovos-skill-count.openvoiceos:count_to_n.intent (Intent)
❌ question:action (Intent)
❌ question:action.ovos-skill-count.openvoiceos (Intent)
❌ question:query (Intent)
❌ homescreen.metadata.get
❌ mycroft.ovos-skill-count.openvoiceos.all_loaded
❌ mycroft.ovos-skill-count.openvoiceos.is_alive
❌ mycroft.ovos-skill-count.openvoiceos.is_ready
❌ mycroft.skill.disable_intent
❌ mycroft.skill.enable_intent
❌ mycroft.skill.remove_cross_context
❌ mycroft.skill.set_cross_context
❌ mycroft.skills.settings.changed
❌ ovos-skill-count.openvoiceos.converse.get_response
❌ ovos-skill-count.openvoiceos.set
❌ ovos.common_query.ping
❌ ovos.skills.settings_changed
✅ Covered Listeners:
✅ mycroft.stop (2x)
✅ ovos-skill-count.openvoiceos.stop (2x)
✅ ovos-skill-count.openvoiceos.stop.ping (2x)
✅ ovos-skill-count.openvoiceos:count_to_n (2x)

📤 Emitters:

✅ mycroft.skill.handler.complete (Asserted ✅)
✅ mycroft.skill.handler.start (Asserted ✅)
✅ ovos-skill-count.openvoiceos.activate (Asserted ✅)
✅ ovos-skill-count.openvoiceos:count_to_n (Asserted ✅)
✅ ovos.intent.handler.complete (Asserted ✅)
✅ ovos.intent.handler.start (Asserted ✅)
✅ ovos.intent.matched (Asserted ✅)
✅ ovos.utterance.handled (Asserted ✅)

`ovos-skill-hello-world.openvoiceos`

⚠️ Uncovered Listeners:

❌ ovos-skill-hello-world.openvoiceos:Greetings (Intent)
❌ ovos-skill-hello-world.openvoiceos:Greetings.intent (Intent)
❌ ovos-skill-hello-world.openvoiceos:HelloWorldIntent (Intent)
❌ ovos-skill-hello-world.openvoiceos:HowAreYou (Intent)
❌ ovos-skill-hello-world.openvoiceos:HowAreYou.intent (Intent)
❌ ovos-skill-hello-world.openvoiceos:ThankYouIntent (Intent)
❌ question:action (Intent)
❌ question:action.ovos-skill-hello-world.openvoiceos (Intent)
❌ question:query (Intent)
❌ hello.world
❌ homescreen.metadata.get
❌ mycroft.ovos-skill-hello-world.openvoiceos.all_loaded
❌ mycroft.ovos-skill-hello-world.openvoiceos.is_alive
❌ mycroft.ovos-skill-hello-world.openvoiceos.is_ready
❌ mycroft.skill.disable_intent
❌ mycroft.skill.enable_intent
❌ mycroft.skill.remove_cross_context
❌ mycroft.skill.set_cross_context
❌ mycroft.skills.settings.changed
❌ mycroft.stop
❌ ovos-skill-hello-world.openvoiceos.converse.get_response
❌ ovos-skill-hello-world.openvoiceos.set
❌ ovos-skill-hello-world.openvoiceos.stop
❌ ovos-skill-hello-world.openvoiceos.stop.ping
❌ ovos.common_query.ping
❌ ovos.skills.settings_changed

`ovos-skill-parrot.openvoiceos`

⚠️ Uncovered Listeners:

❌ ovos-skill-parrot.openvoiceos:did_you_hear_me (Intent)
❌ ovos-skill-parrot.openvoiceos:did_you_hear_me.intent (Intent)
❌ ovos-skill-parrot.openvoiceos:repeat_stt (Intent)
❌ ovos-skill-parrot.openvoiceos:repeat_stt.intent (Intent)
❌ ovos-skill-parrot.openvoiceos:repeat_tts (Intent)
❌ ovos-skill-parrot.openvoiceos:repeat_tts.intent (Intent)
❌ ovos-skill-parrot.openvoiceos:speak (Intent)
❌ ovos-skill-parrot.openvoiceos:speak.intent (Intent)
❌ ovos-skill-parrot.openvoiceos:start_parrot.intent (Intent)
❌ ovos-skill-parrot.openvoiceos:stop_parrot (Intent)
❌ ovos-skill-parrot.openvoiceos:stop_parrot.intent (Intent)
❌ question:action (Intent)
❌ question:action.ovos-skill-parrot.openvoiceos (Intent)
❌ question:query (Intent)
❌ homescreen.metadata.get
❌ intent.service.skills.activated
❌ intent.service.skills.deactivated
❌ mycroft.ovos-skill-parrot.openvoiceos.all_loaded
❌ mycroft.ovos-skill-parrot.openvoiceos.is_alive
❌ mycroft.ovos-skill-parrot.openvoiceos.is_ready
❌ mycroft.skill.disable_intent
❌ mycroft.skill.enable_intent
❌ mycroft.skill.remove_cross_context
❌ mycroft.skill.set_cross_context
❌ mycroft.skills.settings.changed
❌ ovos-skill-parrot.openvoiceos.converse.get_response
❌ ovos-skill-parrot.openvoiceos.deactivate
❌ ovos-skill-parrot.openvoiceos.set
❌ ovos-skill-parrot.openvoiceos.stop
❌ ovos-skill-parrot.openvoiceos.stop.ping
❌ ovos.common_query.ping
❌ ovos.skills.settings_changed
❌ speak
✅ Covered Listeners:
✅ mycroft.stop (2x)
✅ ovos-skill-parrot.openvoiceos.activate (6x)
✅ ovos-skill-parrot.openvoiceos.converse.ping (6x)
✅ ovos-skill-parrot.openvoiceos.converse.request (4x)
✅ ovos-skill-parrot.openvoiceos:start_parrot (2x)
✅ recognizer_loop:utterance (12x)

📤 Emitters:

✅ converse:skill (Asserted ✅)
✅ mycroft.skill.handler.complete (Asserted ✅)
✅ mycroft.skill.handler.start (Asserted ✅)
✅ ovos-skill-parrot.openvoiceos.activate (Asserted ✅)
✅ ovos-skill-parrot.openvoiceos.converse.request (Asserted ✅)
✅ ovos-skill-parrot.openvoiceos:start_parrot (Asserted ✅)
✅ ovos.intent.matched (Asserted ✅)
✅ ovos.utterance.handled (Asserted ✅)
✅ ovos.utterance.speak (Asserted ✅)
✅ skill.converse.pong (Asserted ✅)
✅ skill.converse.response (Asserted ✅)

`stop.openvoiceos`

📤 Emitters:

✅ mycroft.skill.handler.complete (Asserted ✅)
✅ mycroft.skill.handler.start (Asserted ✅)
✅ mycroft.stop (Asserted ✅)
✅ ovos-skill-count.openvoiceos.stop (Asserted ✅)
✅ ovos.utterance.handled (Asserted ✅)
✅ stop.openvoiceos.activate (Asserted ✅)
✅ stop:global (Asserted ✅)
✅ stop:skill (Asserted ✅)

`type`

⚠️ Uncovered Listeners:

❌ recognizer_loop:record_begin (Intent)
❌ recognizer_loop:record_end (Intent)
✅ Covered Listeners:
✅ recognizer_loop:audio_output_end (13x)
✅ recognizer_loop:audio_output_start (14x)

⚖️ License Check

I've verified the attribution of all third-party code. 👤

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔎 Type Check

Ensuring your contribution is moving forward. 🚀

❌ mypy: 276 error(s) found

ovos_core/main.py:24:1: error: Skipping analyzing "ovos_utils.log": module is installed, but missing library stubs or py.typed marker [import-untyped]

Errors (showing first 10/276)

test/unittests/test_skill/__init__.py:15:1: error: Skipping analyzing "ovos_workshop.skills.ovos": module is installed, but missing library stubs or py.typed marker  [import-untyped]
test/end2end/conftest.py:10:1: error: Cannot find implementation or library stub for module named "pytest"  [import-not-found]
ovos_core/transformers.py:3:1: error: Skipping analyzing "ovos_config": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:4:1: error: Skipping analyzing "ovos_plugin_manager.intent_transformers": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:5:1: error: Skipping analyzing "ovos_plugin_manager.metadata_transformers": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:6:1: error: Skipping analyzing "ovos_plugin_manager.text_transformers": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/transformers.py:7:1: error: Skipping analyzing "ovos_plugin_manager.transformer_services": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/intent_services/manifest.py:15:1: error: Skipping analyzing "ovos_bus_client.message": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/intent_services/manifest.py:16:1: error: Skipping analyzing "ovos_spec_tools": module is installed, but missing library stubs or py.typed marker  [import-untyped]
ovos_core/intent_services/manifest.py:17:1: error: Skipping analyzing "ovos_utils.log": module is installed, but missing library stubs or py.typed marker  [import-untyped]

The automation never sleeps, but I might reboot. 💤

…struction order

…full-compat rebuild v3

github-actions Bot added the fix label Aug 13, 2026

fix: connect SessionManager to the bus exactly once regardless of con…

c1d5a71

…struction order

JarbasAl force-pushed the fix/skillmanager-sessionmanager-bus branch from 78c27fc to c1d5a71 Compare August 13, 2026 02:50

github-actions Bot added fix and removed fix labels Aug 13, 2026

JarbasAl added a commit that referenced this pull request Aug 13, 2026

Merge PR #855 (fix/skillmanager-sessionmanager-bus) into integration/…

9a12901

…full-compat rebuild v3

JarbasAl marked this pull request as ready for review August 13, 2026 22:33

JarbasAl merged commit b452ed8 into dev Aug 13, 2026
19 checks passed

JarbasAl deleted the fix/skillmanager-sessionmanager-bus branch August 13, 2026 22:33

github-actions Bot added fix and removed fix labels Aug 13, 2026

Uh oh!

Uh oh!

Conversation

JarbasAl commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

github-actions Bot commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Another day, another set of automated checks. Let's see! 🌅

🏷️ Release Preview

🔒 Security (pip-audit)

🌍 Locale Build

📚 Docs

📋 Repo Health

🔌 Plugin Detection

📊 Coverage

🔨 Build Tests

🔌 Skill Tests (ovoscope)

🚌 Bus Coverage

🔴 Coverage Summary

📊 Per-Skill Breakdown

AdaptPipeline

ConverseService

DomainAdaptPipeline

FallbackService

HierarchicalAdaptPipeline

IntentDispatcher

IntentManifest

IntentService

Model2VecPrototypePipeline

PadaciosoPipeline

PadatiousPipeline

SkillManager

StopService

__core__

ovos-skill-count.openvoiceos

ovos-skill-hello-world.openvoiceos

ovos-skill-parrot.openvoiceos

stop.openvoiceos

type

⚖️ License Check

🔎 Type Check

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

JarbasAl commented Aug 13, 2026 •

edited

Loading

coderabbitai Bot commented Aug 13, 2026 •

edited

Loading

github-actions Bot commented Aug 13, 2026 •

edited

Loading

`AdaptPipeline`

`ConverseService`

`DomainAdaptPipeline`

`FallbackService`

`HierarchicalAdaptPipeline`

`IntentDispatcher`

`IntentManifest`

`IntentService`

`Model2VecPrototypePipeline`

`PadaciosoPipeline`

`PadatiousPipeline`

`SkillManager`

`StopService`

`core`

`ovos-skill-count.openvoiceos`

`ovos-skill-hello-world.openvoiceos`

`ovos-skill-parrot.openvoiceos`

`stop.openvoiceos`

`type`