Conversation
Member
|
Probably better to make the commit message and PR say "Replace SCons buildsystem with CMake" or such. |
Spartan322
added
the
enhancement
FakeByte
marked this pull request as ready for review
July 29, 2026 11:10
FakeByte
enabled auto-merge
July 29, 2026 11:11
Spartan322
approved these changes
Jul 29, 2026
Spartan322
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces scons with cmake
All third party submodules are removed from the repo and are now fetched with fetch content from cmake
The scripts repo is also fetched by fetch content, if run from the main repo then its only fetched a single time instead of having the submodule 4 times in the repo.