Skip to content

feat(gam): close general-family multismooth surfaces - #27

Merged
Ananyapam7 merged 1 commit into
mainfrom
feature/mgcv-wave1-general-multismooth
Aug 24, 2026
Merged

feat(gam): close general-family multismooth surfaces#27
Ananyapam7 merged 1 commit into
mainfrom
feature/mgcv-wave1-general-multismooth

Conversation

@Ananyapam7

Copy link
Copy Markdown
Collaborator

Summary

  • exercise and verify wrapped multi-smooth Sl blocks across both predictors of an mgcv::gaulss model
  • align public parametric and smooth labels with mgcv formula-list predictor suffixes across summary, ANOVA, diagnostics, plots, derivatives, snapshots, and gam.vcomp
  • add vendored-mgcv fixtures covering smoothing selection, sp.vcov, one-SE selection, covariance variants, likelihood criteria, inference, residuals, concurvity, and k.check

Upstream parity anchors

  • mgcv::gam, gam.setup.list, Sl.setup, Sl.initial.repara
  • summary.gam, anova.gam, sp.vcov, one.se.rule, gam.vcomp
  • concurvity, k.check, residuals.gam

Verification

  • ruff check nampy/gam tests/families/test_general_family_mgcv_parity.py tests/optimization/test_mgcv_general_family_preoptimization_parity.py tests/parity/test_mgcv_general_family_prediction_filters_parity.py tests/parity/test_mgcv_snapshot_extended_matrix.py
  • git diff --check
  • affected suite: 93 passed, 66 deselected
  • final exact-node rerun: wrapped-block setup 1 passed; comprehensive snapshot 1 passed; prediction filters/labels 8 passed

Remaining scope

Wave 1 is complete after this subwave. Remaining planned work is the bounded Wave 2 basis-family sequence (cp, bs, ds, gp, mrf, sos).

@Ananyapam7
Ananyapam7 merged commit 0082312 into main Aug 24, 2026
6 of 8 checks passed
@Ananyapam7
Ananyapam7 deleted the feature/mgcv-wave1-general-multismooth branch August 24, 2026 20:42
Ananyapam7 added a commit that referenced this pull request Aug 25, 2026
Co-authored-by: Ananyapam De <ananyapam7@tu-clausthal.de>
Ananyapam7 added a commit that referenced this pull request Aug 25, 2026
Co-authored-by: Ananyapam De <ananyapam7@tu-clausthal.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant