Update Font modifiers#943
Merged
Merged
Conversation
Kyle-Ye
marked this pull request as ready for review
July 19, 2026 10:56
🤖 Augment PR SummarySummary: This PR completes the remaining Changes:
Technical Notes: The CoreText path now builds descriptors via symbolic traits, feature/variation attributes, and UI-type descriptor creation; non-CoreText builds retain API surface via minimal placeholder types and warnings. 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
- Coverage 26.35% 26.29% -0.07%
==========================================
Files 723 724 +1
Lines 51232 51368 +136
==========================================
+ Hits 13504 13505 +1
- Misses 37728 37863 +135 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Kyle-Ye
force-pushed
the
feature/font_modifier
branch
from
July 19, 2026 12:40
a6da354 to
b6c78b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FontmodifiersImpact
This completes the modifier paths used to derive CoreText font descriptors while keeping unsupported platforms on an explicit, non-crashing fallback path.
Validation
git diff --check