Add image attachment support to Text#941
Conversation
🤖 Augment PR SummarySummary: This PR adds support for embedding images directly into Changes:
Technical Notes: Attachment resolution uses 🤖 Was this summary useful? React with 👍 or 👎 |
| options: Text.ResolveOptions | ||
| ) -> Bool where T: ResolvedTextContainer { | ||
| guard options.contains(.writeAuxiliaryMetadata), | ||
| let image = image.resolveNamedImage(in: context) |
There was a problem hiding this comment.
Sources/OpenSwiftUICore/View/Text/Text/Text+Image.swift:L96: image.resolveNamedImage(in:) internally calls resolve(in:); when it returns nil (e.g., missing named asset) the fallback path resolves again, which can duplicate the external warning log and do the resolution work twice on the error path.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
+ Coverage 25.68% 26.36% +0.67%
==========================================
Files 722 723 +1
Lines 51190 51232 +42
==========================================
+ Hits 13150 13506 +356
+ Misses 38040 37726 -314 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Text.init(_ image:)for embedding images in text.Imageinterpolation inLocalizedStringKey.