Update Text.resolve implementation#940
Merged
Merged
Conversation
🤖 Augment PR SummarySummary: This PR substantially completes the
🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
|
|
||
| // FIXME | ||
| public struct Shading: Sendable {} |
There was a problem hiding this comment.
Sources/OpenSwiftUICore/Graphic/GraphicsContext.swift:516: Since Shading is part of an @_silgen_name signature that can call into SwiftUI when OPENSWIFTUI_SWIFTUI_RENDERER is enabled, an empty placeholder type risks an ABI mismatch/undefined behavior at runtime. Consider ensuring this type’s layout matches SwiftUI’s GraphicsContext.Shading (even when you only ever pass nil).
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Text.resolve,Text.Resolved, and resolved text append paths for strings, attributed strings, image attachments, named images, and resolvable text segments.Text.Style, modifier, foreground style, font, line style, and renderer APIs.