Skip to content

Fix inverted badge type null check on ticket data import #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JpMaxMan wants to merge 2 commits into from
+47 −1
Closed

Fix inverted badge type null check on ticket data import #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
152fe31
fix(registration): create badge from type on ticket data import
JpMaxMan Jul 2, 2026
c1a769b
test(registration): build a badge-less ticket for the badge-creation …
JpMaxMan Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Services/Model/Imp/SummitOrderService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4614,7 +4614,7 @@ public function processTicketData(int $summit_id, string $filename)

if (!$ticket->hasBadge()) {
// create it
if (!is_null($badge_type)) {
if (is_null($badge_type)) {
Log::warning("SummitOrderService::processTicketData badge type is null stop current row processing.");
return;
}
Expand Down
46 changes: 46 additions & 0 deletions tests/SummitOrderServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,4 +678,50 @@ public function testImportTicketDataBadgeFeaturesStillClearedAndReSet()
$this->assertNotNull($answer);
$this->assertEquals('Vegan', $answer->getValue());
}

public function testImportTicketDataCreatesBadgeWhenTicketHasNone()
{
Queue::fake();

// every fixture ticket type carries a badge type, so SummitTicketType::applyTo
// auto-creates a badge at setTicketType time — build a ticket from a type with
// no badge type to get a genuinely badge-less ticket
$ticket_type = new SummitTicketType();
$ticket_type->setName('NO BADGE TICKET TYPE');
$ticket_type->setCost(100);
$ticket_type->setCurrency('USD');
$ticket_type->setQuantity2Sell(10);
$ticket_type->setAudience(SummitTicketType::Audience_All);
self::$summit->addTicketType($ticket_type);

$order = new SummitOrder();
$order->setOwner(self::$defaultMember);
$order->setSummit(self::$summit);
self::$summit->addOrder($order);

$ticket = new SummitAttendeeTicket();
$ticket->setTicketType($ticket_type);
$ticket->activate();
$order->addTicket($ticket);
$order->setPaid();
$order->generateNumber();
$ticket->generateNumber();
$ticket->generateQRCode();

self::$em->persist(self::$summit);
self::$em->flush();

$this->assertFalse($ticket->hasBadge());

$csv_content = <<<CSV
number,attendee_email,attendee_first_name,attendee_last_name,badge_type_name
{$ticket->getNumber()},new.attendee@nowhere.com,New,Attendee,BADGE TYPE1
CSV;

$service = $this->buildTicketDataImportService($csv_content);
$service->processTicketData(self::$summit->getId(), 'tickets.csv');

$this->assertTrue($ticket->hasBadge());
$this->assertEquals('BADGE TYPE1', $ticket->getBadge()->getType()->getName());
}
}
Loading