Check the OSSL_PARAM type before reading the RSA-PSS salt length - #668
Merged
Conversation
Previously, string parameters were passed to OSSL_PARAM_get_int() first, leaving a spurious "incompatible type" error in the OpenSSL error queue even when string parsing succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Issue number: N/A
Current Behavior
RSA-PSS salt length parameters are parsed by trying integer and string conversions without first validating the parameter type.
New Behavior
Unsupported or malformed parameter types are rejected explicitly.
Scope of Changes
Validate the
OSSL_SIGNATURE_PARAM_PSS_SALTLENdata type before parsing integer and UTF-8 string values.Testing
Additional Notes
License Declaration