Skip to content

fix: CodeQL CDN SRI, HTML escaping, and ReDoS #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veillette merged 1 commit into from
Aug 12, 2026
Merged

fix: CodeQL CDN SRI, HTML escaping, and ReDoS #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions examples/code-playground.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,19 +357,19 @@ <h1>Live Code Playground</h1>
</div>
</div>

<!-- CodeMirror JS -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/codemirror.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/mode/javascript/javascript.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/addon/edit/closebrackets.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/addon/edit/matchbrackets.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/addon/hint/show-hint.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/addon/hint/javascript-hint.min.js"></script>
<!-- CodeMirror JS (SRI: cdnjs CodeMirror 5.65.20) -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/codemirror.min.js" integrity="sha512-hJEMjfR4ds7mXbBot3i/R+CsiyYpeWSezXul8uLBT8wXAHPUdhRgl4LLTtMGwjarftGKiQqK1v20XScm0ANTPQ==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/mode/javascript/javascript.min.js" integrity="sha512-Cbz+kvn+l5pi5HfXsEB/FYgZVKjGIhOgYNBwj4W2IHP2y8r3AdyDCQRnEUqIQ+6aJjygKPTyaNT2eIihaykJlw==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/addon/edit/closebrackets.min.js" integrity="sha512-tsjcYO5hFvViRssxiM7Jhd8601epWOx1He3Hl4yuI5dKKPxr43KxkOhc9GZeeqzlYJm9ABb7UPA9697NiqZZ7Q==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/addon/edit/matchbrackets.min.js" integrity="sha512-GSYCbN/le5gNmfAWVEjg1tKnOH7ilK6xCLgA7c48IReoIR2g2vldxTM6kZlN6o3VtWIe6fHu/qhwxIt11J8EBA==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/addon/hint/show-hint.min.js" integrity="sha512-+Vu6KfeJ+ak4ipbxtjUR3b1M/yklDlglRB/03ZsMzu1E/FQ+AL7D88THTyigWmh0xqXnP7pV9myEqac9C2N+2A==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.65.20/addon/hint/javascript-hint.min.js" integrity="sha512-omIxBxPdObb7b3giwJtPBiB86Mey/ds7qyKFcRiaLQgDxoSR+UgCYEFO7jRZzPOCZAICabGCraEhOSa71U1zFA==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>

<script type="module">
import CD48, { setupDevMode } from '../dist/cd48.esm.js';

// Setup dev mode
const { logger } = setupDevMode({
setupDevMode({
logger: { enabled: true, level: 'debug' },
showOverlay: true,
});
Expand Down
7 changes: 5 additions & 2 deletions src/cd48.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,11 @@ class CD48 {
minor: number;
patch: number;
} {
// Extract version number pattern (e.g., "1.2.3" or "1.2")
const match = versionString.match(/(\d+)\.(\d+)(?:\.(\d+))?/);
// Extract version number pattern (e.g., "1.2.3" or "1.2"). Bounded repeats
// avoid polynomial backtracking on crafted inputs (CodeQL js/polynomial-redos).
const match = versionString.match(
/(\d{1,10})\.(\d{1,10})(?:\.(\d{1,10}))?/
);
if (match !== null) {
return {
major: Number.parseInt(match[1] ?? '0', DECIMAL_RADIX),
Expand Down
2 changes: 1 addition & 1 deletion src/dev-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ export class ErrorOverlay {

<div style="background: #1a1f3a; padding: 20px; border-radius: 8px; margin-bottom: 20px; border-left: 4px solid #ef4444;">
<div style="color: #ef4444; font-weight: bold; margin-bottom: 10px;">
${error.name !== '' ? error.name : 'Error'}
${this.escapeHtml(error.name !== '' ? error.name : 'Error')}
</div>
<div style="color: #eee; font-size: 16px; margin-bottom: 15px;">
${this.escapeHtml(error.message)}
Expand Down
Loading