Skip to content

fix: clear CodeQL useless-assignment in build-data #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veillette merged 1 commit into from
Aug 12, 2026
Merged

fix: clear CodeQL useless-assignment in build-data #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions scripts/build-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,13 +1019,12 @@ interface VolcanoBuild {
async function buildVolcanoes(plates: readonly PlateBuild[]): Promise<VolcanoBuild[]> {
const volcanoes: VolcanoBuild[] = [];
let page = 1;
let totalPages = 1;
do {
for (;;) {
const response = await fetchJson<{ items: readonly VolcanoLocation[]; totalPages: number }>(
`${VOLCANO_QUERY}?itemsPerPage=100&page=${page}`,
`volcanoes_${page}.json`,
);
totalPages = response.totalPages;
const totalPages = response.totalPages;
for (const item of response.items) {
if (typeof item.latitude !== "number" || typeof item.longitude !== "number") {
continue;
Expand All @@ -1039,7 +1038,10 @@ async function buildVolcanoes(plates: readonly PlateBuild[]): Promise<VolcanoBui
});
}
page += 1;
} while (page <= totalPages);
if (page > totalPages) {
break;
}
}

const entries = volcanoes.map(
(volcano) =>
Expand Down