Skip to content

in2TopoHyd and simulation results are named as the XSECT shp file - #124

Open
PaulaSp3 wants to merge 6 commits into
masterfrom
PS_fileNamesIn2
Open

in2TopoHyd and simulation results are named as the XSECT shp file#124
PaulaSp3 wants to merge 6 commits into
masterfrom
PS_fileNamesIn2

Conversation

@PaulaSp3

@PaulaSp3 PaulaSp3 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@PaulaSp3 PaulaSp3 self-assigned this Nov 10, 2026
@PaulaSp3 PaulaSp3 added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 10, 2026
@PaulaSp3 PaulaSp3 linked an issue Nov 10, 2026 that may be closed by this pull request
Better naming options coming from in2topoHyd #108
Open
@PaulaSp3
PaulaSp3 requested review from JuLa96 and fso42 November 10, 2026 15:26
@qltysh

qltysh Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
debrisframe/tests/test_fileUtils.py100.0%
Coverage rating: A Coverage rating: A
debrisframe/tests/test_plotUtils.py100.0%
Total100.0%
Commit 971d677 · 🚦 See full report on Qlty Cloud »

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

JuLa96
JuLa96 approved these changes Nov 11, 2026
View reviewed changes

@JuLa96 JuLa96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is meaningful if the file names of the plots include the cross-section name: crossSection_.png, ratingCurve_.png ?
Small modifications in in1Utils.plotUtils.py would be required.

@PaulaSp3

PaulaSp3 commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Good idea! I've added the renaming of the plots and crossSection.csv to include the cross section name.

@PaulaSp3
PaulaSp3 requested review from JuLa96 and fso42 November 11, 2026 12:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuLa96 JuLa96 JuLa96 approved these changes
@fso42 fso42 Awaiting requested review from fso42

Assignees

@PaulaSp3 PaulaSp3

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better naming options coming from in2topoHyd

3 participants

@PaulaSp3 @fso42 @JuLa96