Repository navigation
Conversation
Contributor
Analysis for project
|
| Tool | Category | Rule | Count | |
|---|---|---|---|---|
| black | Style | Incorrect formatting, autoformat by running qlty fmt. |
2 | ❌ |
@qltysh one-click actions:
- Auto-fix formatting (
qlty fmt && git push)
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
Contributor
|
closes OpenNHM/DebrisFrame#120 |
PaulaSp3
requested changes
Nov 10, 2026
| the flow density ``rho`` (probably the bulk density was entered) or if :math:`c_\gamma \neq 5/2`. | ||
|
|
||
| .. Note:: With :eq:`muI-inertial` and :eq:`muI-shearRate`, :math:`I / I_0` depends on :math:`d`, :math:`I_0` and | ||
| :math:`\rho_g` only through the combination :math:`d / (I_0 \sqrt{\rho / \rho_g})` (:math:`\rho` is the flow |
Contributor
There was a problem hiding this comment.
For the fit below, do you consider flow density rho?
If not, it's easier to understand (IMO) to not mention flow density here, if it is consider I suggest mention the used flow density values.
Contributor
There was a problem hiding this comment.
Maybe it makes sense to clarify the difference between depth and thickness, e.g. that other references use depth-averaged model, but the mu(I) model is transferable to thickness-averaged models, that's why we're talking about thickness?
| \overline{u}^* = \frac{2}{5}\,\frac{I^*}{d}\,\sqrt{\frac{\rho}{\rho_g}\,g\cos\theta}\;\overline{h}^{3/2} | ||
| :label: muI-steady | ||
|
|
||
| which is the Pouliquen flow rule :math:`Fr = \beta\,h / h_{stop}(\theta)` with |
Contributor
There was a problem hiding this comment.
Suggested change
| which is the Pouliquen flow rule :math:`Fr = \beta\,h / h_{stop}(\theta)` with | |
| which is the Pouliquen flow rule describing the Froud number as :math:`Fr = \beta\,h / h_{stop}(\theta)` with |
| :math:`\beta = \frac{2}{5}\,I_0\,\sqrt{(\rho / \rho_g)\cos\theta}` :cite:`GrEd2014`. Equation | ||
| :eq:`muI-steady` is used as the analytic reference in the unit tests. Consequences: | ||
|
|
||
| - Below :math:`\mu_s` the flow stops (the friction force equals the driving force at rest, as for Coulomb friction). |
Contributor
There was a problem hiding this comment.
Suggested change
| - Below :math:`\mu_s` the flow stops (the friction force equals the driving force at rest, as for Coulomb friction). | |
| - Below :math:`\arctan\mu_s` the flow stops (the friction force equals the driving force at rest, as for Coulomb friction). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds first draft of mu(I) rheology
PR Checklist
Please confirm before requesting review:
pytestlocally without failsConfirm before the final merge/rebase into master