Repository navigation
[com1]: stopping option for implicit friction; sfcChangeCum output file - #1343
Merged
Merged
Conversation
Contributor
Analysis for project
|
| Tool | Category | Rule | Count | |
|---|---|---|---|---|
| ruff | Lint | f-string without any placeholders | 1 | ❌ |
| black | Style | Incorrect formatting, autoformat by running qlty fmt. |
1 | ❌ |
| qlty | Structure | Function with high complexity (count = 19): mergePartArea | 1 | |
| qlty | Structure | Deeply nested control flow (level = 4) | 1 |
@qltysh one-click actions:
- Auto-fix formatting (
qlty fmt && git push)
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Components (1)
Modified Files with Diff Coverage (3)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
awirb
reviewed
Nov 3, 2026
fso42
requested changes
Nov 9, 2026
fso42
approved these changes
Nov 10, 2026
PaulaSp3
force-pushed
the
PS_stoppingImplicitFric
branch
from
November 10, 2026 16:17
c0e08dc to
7286e44
Compare
add cumulated sfc change to output files adapt test entrainable deposition is enabled if simType is without ent§ split and merge dmEnt and dmDet correctly update DEM and erodable depth always, only adapt DEM normals and area above a threshold chnage from .copy() to deepcopy comments AW comments FSO
PaulaSp3
force-pushed
the
PS_stoppingImplicitFric
branch
from
November 12, 2026 10:08
7286e44 to
88a6933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

standardTests are ident, except
avaHofSnowGlideTestPR Checklist
Please confirm before requesting review:
pytestlocally without failsConfirm before the final merge/rebase into master